[GitHub] [madlib] makemebitter commented on a change in pull request #422: Correlation: Process deconstruction in chunks for grouping

[GitBox <gi...@apache.org>]

makemebitter commented on a change in pull request #422: Correlation: Process deconstruction in chunks for grouping
URL: https://github.com/apache/madlib/pull/422#discussion_r303111132
 
 

 ##########
 File path: src/ports/postgres/modules/stats/test/correlation.sql_in
 ##########
 @@ -134,3 +147,16 @@ SELECT assert(relative_error(temperature, 17.1500) < 0.0001, 'calculated covaria
 SELECT assert(relative_error(humidity, -28.7000) < 0.0001, 'calculated covariance value ' || humidity || 'does not match expected: ' || -28.7000) FROM example_data_gr2_output_covariance WHERE variable ='new_col' AND gr='1' AND gr2='1';
 
 SELECT assert(relative_error(id, 15.4688) < 0.0001, 'calculated covariance value ' || id || 'does not match expected: ' || 15.4688) FROM example_data_gr2_output_covariance WHERE variable ='new_col' AND gr='1' AND gr2='1';
+
+DROP TABLE IF EXISTS example_data_gr2_output_covariance, example_data_gr2_output_covariance_summary;
+SELECT covariance( 'example_data_gr2',
+                    'example_data_gr2_output_covariance',
+                    'temperature, humidity, id, new_col',
+                    FALSE,
+                    'gr,gr2', 50);
 
 Review comment:
   Do you think it makes sense to assert the count of the output table when grouping is used ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services