[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #6152: [WIP] Basic block normal form

[GitBox <gi...@apache.org>]

MarisaKirisame commented on a change in pull request #6152:
URL: https://github.com/apache/incubator-tvm/pull/6152#discussion_r462680291



##########
File path: src/relay/transforms/to_a_normal_form.cc
##########
@@ -50,10 +50,17 @@ Scope LCA(Scope lhs, Scope rhs) {
   return lhs;
 }
 
-std::unordered_map<DependencyGraph::Node*, Scope> CalcScope(const DependencyGraph& dg) {
-  std::unordered_map<DependencyGraph::Node*, Scope> expr_scope;
+// return a set of Exprs whose scope should be lifted to due dependencies.
+void CalcScope(const DependencyGraph& dg,
+               std::unordered_map<DependencyGraph::Node*, Scope>* expr_scope,

Review comment:
       Why this change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org