[jira] [Commented] (SOLR-8856) Do not cache merge or 'read once' contexts in the hdfs block cache.

["Mike Drob (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204675#comment-15204675 ] 

Mike Drob commented on SOLR-8856:
---------------------------------

bq. +      // we don't cache on merges or when only reading once
This comment needs to be updated to reflect configuration.

{quote}
+        if (cacheMerges) {
+          return true;
+        }
+        return false;

...

+          if (cacheReadOnce) {
+            return true;
+          }
+          return false;
{quote}
Why not {{return cacheMerges}} and {{return cacheReadOnce}}?

{quote}
+  public BlockDirectory(String dirName, Directory directory, Cache cache,
+      Set<String> blockCacheFileTypes, boolean blockCacheReadEnabled,
+      boolean blockCacheWriteEnabled, boolean cacheMerges, boolean cacheReadOnce) throws IOException {
{quote}
What is our compatibility promise? Do we need to maintain the old constructor that is no longer being used?

Alternatively, we're starting to get a lot of parameters here, maybe it is time to use a builder or a configuration object? (Can be a follow-on issue.)

> Do not cache merge or 'read once' contexts in the hdfs block cache.
> -------------------------------------------------------------------
>
>                 Key: SOLR-8856
>                 URL: https://issues.apache.org/jira/browse/SOLR-8856
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: SOLR-8856.patch, SOLR-8856.patch, SOLR-8856.patch
>
>
> Generally the block cache will not be large enough to contain the whole index and merges can thrash the cache for queries. Even if we still look in the cache, we should not populate it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org