You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reswqa (via GitHub)" <gi...@apache.org> on 2023/04/10 17:46:29 UTC

[GitHub] [flink-connector-hbase] reswqa opened a new pull request, #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

reswqa opened a new pull request, #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8

   This should also backports to v3.0 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] reswqa commented on pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#issuecomment-1507130333

   Thanks @TanYuxin-tyx, merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] reswqa commented on a diff in pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#discussion_r1165200592


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########
@@ -38,7 +38,7 @@ HBase 连接器在 upsert 模式下运行,可以使用 DDL 中定义的主键
 依赖
 ------------
 
-{{< sql_download_table "hbase" >}}

Review Comment:
   Yes, but I think it is correct to do this in the external connector repo now, otherwise you need to remember to do it again later. In addition, this will not affect the current document's build process, because `setup-docs.sh` will not link to this external repo now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#issuecomment-1507130686

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#issuecomment-1502107159

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] reswqa merged pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa merged PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] TanYuxin-tyx commented on a diff in pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on code in PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#discussion_r1165192632


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########
@@ -38,7 +38,7 @@ HBase 连接器在 upsert 模式下运行,可以使用 DDL 中定义的主键
 依赖
 ------------
 
-{{< sql_download_table "hbase" >}}

Review Comment:
   I think this is unnecessary. 
   Because HBase connector isn't yet externalized from Flink itself. 
   
   You can ref the comments of this jira https://issues.apache.org/jira/browse/FLINK-31671.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-connector-hbase] TanYuxin-tyx commented on a diff in pull request #8: [FLINK-31759][hbase] Using sql_connector_download_table shortcode for table document.

Posted by "TanYuxin-tyx (via GitHub)" <gi...@apache.org>.
TanYuxin-tyx commented on code in PR #8:
URL: https://github.com/apache/flink-connector-hbase/pull/8#discussion_r1165243353


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########
@@ -38,7 +38,7 @@ HBase 连接器在 upsert 模式下运行,可以使用 DDL 中定义的主键
 依赖
 ------------
 
-{{< sql_download_table "hbase" >}}

Review Comment:
   OK, I think that also makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org