You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "terjekid (via GitHub)" <gi...@apache.org> on 2026/02/12 18:26:23 UTC
[PR] AVRO-4229 - Update StatsServer resource handler [avro]
terjekid opened a new pull request, #3648:
URL: https://github.com/apache/avro/pull/3648
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/main/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
This pull request improves ipc StatsServer, fixing AVRO-4229
## Verifying this change
This change is already covered by existing tests, such as *TestStatsPluginAndServlet*.
## Documentation
- Does this pull request introduce a new feature? *no*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4229 - Update StatsServer resource handler [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #3648:
URL: https://github.com/apache/avro/pull/3648#discussion_r2802572823
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java:
##########
@@ -42,11 +46,24 @@ public StatsServer(StatsPlugin plugin, int port) throws Exception {
this.httpServer = new Server(port);
this.plugin = plugin;
- ServletHandler handler = new ServletHandler();
- httpServer.setHandler(handler);
- handler.addServletWithMapping(new ServletHolder(new StaticServlet()), "/");
+ ServletContextHandler servletContext = new ServletContextHandler(ServletContextHandler.SESSIONS);
+ servletContext.setContextPath("/");
- handler.addServletWithMapping(new ServletHolder(new StatsServlet(plugin)), "/");
+ ServletHolder servletHolder = new ServletHolder(new StatsServlet(plugin));
+ servletContext.addServlet(servletHolder, "/");
+
+ ResourceHandler resourceHandler = new ResourceHandler();
+ resourceHandler.setBaseResource(Resource.newClassPathResource("/org/apache/avro/ipc/stats/static"));
Review Comment:
```suggestion
Resource baseResource = Resource.newClassPathResource("/org/apache/avro/ipc/stats/static");
if (baseResource == null) {
throw new IllegalStateException("Static resources not found on classpath");
}
resourceHandler.setBaseResource(baseResource);
```
since the classpath is provided by another Maven module IMO it would be good to make this check here and fail early if for some reason this package is not available
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java:
##########
Review Comment:
Not caused by this PR but we could improve it.
The ASFv2 licence should be at the top of the file.
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java:
##########
@@ -42,11 +46,24 @@ public StatsServer(StatsPlugin plugin, int port) throws Exception {
this.httpServer = new Server(port);
this.plugin = plugin;
- ServletHandler handler = new ServletHandler();
- httpServer.setHandler(handler);
- handler.addServletWithMapping(new ServletHolder(new StaticServlet()), "/");
+ ServletContextHandler servletContext = new ServletContextHandler(ServletContextHandler.SESSIONS);
+ servletContext.setContextPath("/");
- handler.addServletWithMapping(new ServletHolder(new StatsServlet(plugin)), "/");
+ ServletHolder servletHolder = new ServletHolder(new StatsServlet(plugin));
+ servletContext.addServlet(servletHolder, "/");
+
+ ResourceHandler resourceHandler = new ResourceHandler();
+ resourceHandler.setBaseResource(Resource.newClassPathResource("/org/apache/avro/ipc/stats/static"));
+ resourceHandler.setDirectoriesListed(false); // Optional: prevent directory listing
+
+ ContextHandler staticContext = new ContextHandler();
+ staticContext.setContextPath("/static");
+ staticContext.setHandler(resourceHandler);
+
+ HandlerList handlers = new HandlerList();
+ handlers.setHandlers(new org.eclipse.jetty.server.Handler[] { staticContext, servletContext });
Review Comment:
this can be simplified to:
```suggestion
HandlerList handlers = new HandlerList(staticContext, servletContext);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4229 - Update StatsServer resource handler [avro]
Posted by "terjekid (via GitHub)" <gi...@apache.org>.
terjekid commented on code in PR #3648:
URL: https://github.com/apache/avro/pull/3648#discussion_r2812523480
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java:
##########
@@ -42,11 +46,24 @@ public StatsServer(StatsPlugin plugin, int port) throws Exception {
this.httpServer = new Server(port);
this.plugin = plugin;
- ServletHandler handler = new ServletHandler();
- httpServer.setHandler(handler);
- handler.addServletWithMapping(new ServletHolder(new StaticServlet()), "/");
+ ServletContextHandler servletContext = new ServletContextHandler(ServletContextHandler.SESSIONS);
+ servletContext.setContextPath("/");
- handler.addServletWithMapping(new ServletHolder(new StatsServlet(plugin)), "/");
+ ServletHolder servletHolder = new ServletHolder(new StatsServlet(plugin));
+ servletContext.addServlet(servletHolder, "/");
+
+ ResourceHandler resourceHandler = new ResourceHandler();
+ resourceHandler.setBaseResource(Resource.newClassPathResource("/org/apache/avro/ipc/stats/static"));
Review Comment:
@martin-g I've added a default check and only initialize the static resource handler when the resource folder is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4229 - Update StatsServer resource handler [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #3648:
URL: https://github.com/apache/avro/pull/3648#issuecomment-3912477839
Thank you, @terjekid !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-4229 - Update StatsServer resource handler [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g merged PR #3648:
URL: https://github.com/apache/avro/pull/3648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org