[GitHub] [incubator-superset] john-bodley edited a comment on pull request #9637: [WIP][explore view] add partition as adhoc filter option

[GitBox <gi...@apache.org>]

john-bodley edited a comment on pull request #9637:
URL: https://github.com/apache/incubator-superset/pull/9637#issuecomment-618797080


   @graceguo-superset thanks for adding this. I think directionally it’s correct, i.e., a user friendly mechanism to a feature which only savvy users are probably aware of. 
   
   I agree with @ktmud’s comments including the design suggestion.
   
   It seems like for multi-partitioned tables the REST API call merely returns the value for the first partitioned key and thus in your example it may return the latest `ds` but not the latest `hr`. I think the REST API call may be suffice to get the necessary metadata regarding the partitioned fields however there may need to be a series of hierarchical calls to ensure the correct filters are applied for fetching the latest sub-partition in question.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org