You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/16 04:22:16 UTC

[GitHub] [flink] wuchong commented on a change in pull request #10585: [FLINK-15250][doc] Docs of Table Connect to External Systems is outdate and need to fix

wuchong commented on a change in pull request #10585: [FLINK-15250][doc] Docs of Table Connect to External Systems is outdate and need to fix
URL: https://github.com/apache/flink/pull/10585#discussion_r358048166
 
 

 ##########
 File path: docs/dev/table/connect.md
 ##########
 @@ -127,7 +128,15 @@ schema: ...
 
 <div data-lang="DDL" markdown="1">
 {% highlight sql %}
-tableEnvironment.sqlUpdate("CREATE TABLE MyTable (...) WITH (...)")
+tableEnvironment.sqlUpdate("CREATE TABLE MyTable (...) 
+WITH (
+'connector.key0'='...'
+...
+'connector.keyn'='...'
+'update-mode'='append'
+'format.key0'='...'
+...
+'format.keyn='...')")
 
 Review comment:
   I don't think we should change this. 
   1. It's hard to guess what is `key0` , `keyn`. 
   2. not every connector requirs `update-mode` and `format.*`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services