You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "afs (via GitHub)" <gi...@apache.org> on 2023/07/22 07:32:51 UTC
[GitHub] [jena] afs commented on a diff in pull request #1967: Capabilities and locks
afs commented on code in PR #1967:
URL: https://github.com/apache/jena/pull/1967#discussion_r1271262807
##########
jena-core/src/main/java/org/apache/jena/rdf/model/impl/ModelCom.java:
##########
@@ -1048,32 +1009,26 @@ public int numPrefixes()
{ return getPrefixMapping().numPrefixes() ; }
/**
- Service method to update the namespaces of a Model given the
- mappings from prefix names to sets of URIs.
-
- If the prefix maps to multiple URIs, then we discard it completely.
-
- @param m Model who's namespace is to be updated
- @param ns the namespace map to add to the Model
+ * Service method to update the namespaces of a Model given the mappings from
+ * prefix names to sets of URIs. If the prefix maps to multiple URIs, then we
+ * discard it completely.
+ *
+ * @param m Model who's namespace is to be updated
Review Comment:
Done!
##########
jena-core/src/main/java/org/apache/jena/rdf/model/impl/ModelCom.java:
##########
@@ -1604,9 +1542,8 @@ public GraphListener adapt( final ModelChangedListener L )
{ return new ModelListenerAdapter( this, L ); }
@Override
- public Model notifyEvent( Object e )
- {
- getGraph().getEventManager().notifyEvent( getGraph(), e );
+ public Model notifyEvent(Object e) {
+ getGraph().getEventManager().notifyEvent(getGraph(), e);
return this;
}
-}
+ }
Review Comment:
Good ctach. There's a general misalignment in the latter part of the file. I'll fix that and use the opportunity to reformat he the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org