You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2023/02/27 12:26:56 UTC
Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4091
https://issues.apache.org/jira/browse/RANGER-4091
Repository: ranger
Description
-------
Policy condition window Overlaps with Policy permisions window as Policy condition & Permission window is not closing by any click events
Steps to reproduce :
1. Try to create any tag based policy
2. Click on Policy condition + icon
3. Click on permission + icon
Actual : Policy condition & Permission window is not closing by any click events
Expected : Policy condition & Permission window should close by any click events
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx d2efcb679
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 876afd4f9
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 863ae5e96
Diff: https://reviews.apache.org/r/74323/diff/1/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
-CRUD Operation in Policy module.
-Policy Items tables in Policy Form.
-Permission and policy conditions window.
Thanks,
Brijesh Bhalala
Re: Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/#review225305
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On March 29, 2023, 3:04 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74323/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:04 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4091
> https://issues.apache.org/jira/browse/RANGER-4091
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy condition window Overlaps with Policy permisions window as Policy condition & Permission window is not closing by any click events
>
> Steps to reproduce :
>
> 1. Try to create any tag based policy
> 2. Click on Policy condition + icon
> 3. Click on permission + icon
>
> Actual : Policy condition & Permission window is not closing by any click events
>
> Expected : Policy condition & Permission window should close by any click events
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx d2efcb67976ba7591ee5d02b84b7e6e031af6d0b
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 5d6ad75a14d96298fab65839d7b8cc9c9d3696d4
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx e556e25460010142c675178769bee06f63f68f90
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 863ae5e96bbaf217c0afedfb3e8b3e8c27cc3e4f
>
>
> Diff: https://reviews.apache.org/r/74323/diff/3/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the Following things:-
> -CRUD Operation in Policy module.
> -Policy Items tables in Policy Form.
> -Permission and policy conditions window.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/#review225311
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On March 29, 2023, 3:04 p.m., Brijesh Bhalala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74323/
> -----------------------------------------------------------
>
> (Updated March 29, 2023, 3:04 p.m.)
>
>
> Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
>
>
> Bugs: RANGER-4091
> https://issues.apache.org/jira/browse/RANGER-4091
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Policy condition window Overlaps with Policy permisions window as Policy condition & Permission window is not closing by any click events
>
> Steps to reproduce :
>
> 1. Try to create any tag based policy
> 2. Click on Policy condition + icon
> 3. Click on permission + icon
>
> Actual : Policy condition & Permission window is not closing by any click events
>
> Expected : Policy condition & Permission window should close by any click events
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx d2efcb67976ba7591ee5d02b84b7e6e031af6d0b
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 5d6ad75a14d96298fab65839d7b8cc9c9d3696d4
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx e556e25460010142c675178769bee06f63f68f90
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 863ae5e96bbaf217c0afedfb3e8b3e8c27cc3e4f
>
>
> Diff: https://reviews.apache.org/r/74323/diff/3/
>
>
> Testing
> -------
>
> 1)Build and Verified Ranger Admin setup with this changes.
> 2)Verified the Following things:-
> -CRUD Operation in Policy module.
> -Policy Items tables in Policy Form.
> -Permission and policy conditions window.
>
>
> Thanks,
>
> Brijesh Bhalala
>
>
Re: Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/
-----------------------------------------------------------
(Updated March 29, 2023, 3:04 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4091
https://issues.apache.org/jira/browse/RANGER-4091
Repository: ranger
Description
-------
Policy condition window Overlaps with Policy permisions window as Policy condition & Permission window is not closing by any click events
Steps to reproduce :
1. Try to create any tag based policy
2. Click on Policy condition + icon
3. Click on permission + icon
Actual : Policy condition & Permission window is not closing by any click events
Expected : Policy condition & Permission window should close by any click events
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx d2efcb67976ba7591ee5d02b84b7e6e031af6d0b
security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb4413733c9e51052b8e42f4b67017c2a203b3c
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 5d6ad75a14d96298fab65839d7b8cc9c9d3696d4
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx e556e25460010142c675178769bee06f63f68f90
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 863ae5e96bbaf217c0afedfb3e8b3e8c27cc3e4f
Diff: https://reviews.apache.org/r/74323/diff/3/
Changes: https://reviews.apache.org/r/74323/diff/2-3/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
-CRUD Operation in Policy module.
-Policy Items tables in Policy Form.
-Permission and policy conditions window.
Thanks,
Brijesh Bhalala
Re: Review Request 74323: RANGER-4091 : Policy condition & Permission window should close by any click events
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74323/
-----------------------------------------------------------
(Updated March 20, 2023, 1:31 p.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4091
https://issues.apache.org/jira/browse/RANGER-4091
Repository: ranger
Description
-------
Policy condition window Overlaps with Policy permisions window as Policy condition & Permission window is not closing by any click events
Steps to reproduce :
1. Try to create any tag based policy
2. Click on Policy condition + icon
3. Click on permission + icon
Actual : Policy condition & Permission window is not closing by any click events
Expected : Policy condition & Permission window should close by any click events
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx d2efcb679
security-admin/src/main/webapp/react-webapp/src/styles/style.css 1cb441373
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 5d6ad75a1
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx e556e2546
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 863ae5e96
Diff: https://reviews.apache.org/r/74323/diff/2/
Changes: https://reviews.apache.org/r/74323/diff/1-2/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the Following things:-
-CRUD Operation in Policy module.
-Policy Items tables in Policy Form.
-Permission and policy conditions window.
Thanks,
Brijesh Bhalala