You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/13 12:19:00 UTC
[jira] [Commented] (CB-13999) Reading config.xml on browser
platform does not respect base href
[ https://issues.apache.org/jira/browse/CB-13999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613400#comment-16613400 ]
ASF GitHub Bot commented on CB-13999:
-------------------------------------
jenshelderweirdt opened a new pull request #60: CB-13999: (browser) - Reading config.xml respects base href
URL: https://github.com/apache/cordova-browser/pull/60
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Browser
### What does this PR do?
Link to config.xml using the base href instead of the root (removed the trailing /)
### What testing has been done on this change?
Manual testing in an Ionic/Cordova project
### Checklist
- [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ X] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Reading config.xml on browser platform does not respect base href
> -----------------------------------------------------------------
>
> Key: CB-13999
> URL: https://issues.apache.org/jira/browse/CB-13999
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-browser
> Affects Versions: cordova@7.0.0
> Reporter: Geoff Tripoli
> Assignee: Jesse MacFadyen
> Priority: Minor
> Labels: config.xml
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> If you use a custom base href in your index html, the preceding "/" in the xhr that gets the config.xml will cause the base to be ignored.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org