You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/21 17:16:44 UTC

[GitHub] [flink] miklosgergely opened a new pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

miklosgergely opened a new pull request #14450:
URL: https://github.com/apache/flink/pull/14450


   ## What is the purpose of the change
   
   flink-connector-hbase-base has some unnecessary dependencies, they should be removed / moved to flink-connector-hbase-1.4
   
   ## Brief change log
   
   flink-connector-hbase-base no longer depends on hbase-server, just hbase-client. flink-connector-hbase-1.4 has hbase-server as test dependency.
   
   ## Verifying this change
   
   HBase connector projects still build fine, tests are fine too.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-749103814


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11135",
       "triggerID" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3db05579ef81d65b1c6c3a3cadc53c266bfe4dff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11135) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #14450:
URL: https://github.com/apache/flink/pull/14450


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-749103814


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3db05579ef81d65b1c6c3a3cadc53c266bfe4dff UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-749094234


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3db05579ef81d65b1c6c3a3cadc53c266bfe4dff (Mon Dec 21 17:18:53 UTC 2020)
   
   **Warnings:**
    * **2 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-19971).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] miklosgergely commented on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
miklosgergely commented on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-754091098


   @rmetzger could you please review?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-760714424


   I'll take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-749103814


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11135",
       "triggerID" : "3db05579ef81d65b1c6c3a3cadc53c266bfe4dff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3db05579ef81d65b1c6c3a3cadc53c266bfe4dff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11135) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14450: [FLINK-19971][hbase] Fix HBase connector dependencies

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14450:
URL: https://github.com/apache/flink/pull/14450#issuecomment-749094234


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 3db05579ef81d65b1c6c3a3cadc53c266bfe4dff (Fri May 28 07:08:24 UTC 2021)
   
   **Warnings:**
    * **2 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org