You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/08 03:41:37 UTC

[GitHub] [incubator-doris] HappenLee commented on a change in pull request #6515: [Memory] BitShufflePageDecoder use memory allocated by ChunkAllocator instead of Faststring

HappenLee commented on a change in pull request #6515:
URL: https://github.com/apache/incubator-doris/pull/6515#discussion_r744386965



##########
File path: be/src/olap/rowset/segment_v2/bitshuffle_page.h
##########
@@ -385,7 +394,7 @@ class BitShufflePageDecoder : public PageDecoder {
 
     int _size_of_element;
     size_t _cur_index;
-    faststring _decoded;
+    Chunk chunk;

Review comment:
       '_chunk` not ‘chunk’




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org