You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2014/05/27 15:14:13 UTC
Review Request 21925: QPID-5773: revert non-essential recv path change from
QPID-4872
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21925/
-----------------------------------------------------------
Review request for qpid and Justin Ross.
Bugs: qpid-5773
https://issues.apache.org/jira/browse/qpid-5773
Repository: qpid
Description
-------
For bug QPID-4872, I modified both the receive path and the send path in the transport code. Turns out only the send path is necessary - the original bug will not present on the receive path (checked the python code and openssl sources to confirm). The change to the receive path is actually less efficient as some versions of python merely implement recv_into by allocating a temp buffer and calling recv then doing a copy into the passed buffer!
This change reverts the recv side of QPID-4872.
Diffs
-----
Diff: https://reviews.apache.org/r/21925/diff/
Testing
-------
SSL unit tests.
Thanks,
Kenneth Giusti
Re: Review Request 21925: QPID-5773: revert non-essential recv path change
from QPID-4872
Posted by Justin Ross <jr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21925/#review44258
-----------------------------------------------------------
Ship it!
I approve.
- Justin Ross
On May 27, 2014, 1:20 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21925/
> -----------------------------------------------------------
>
> (Updated May 27, 2014, 1:20 p.m.)
>
>
> Review request for qpid and Justin Ross.
>
>
> Bugs: qpid-5773
> https://issues.apache.org/jira/browse/qpid-5773
>
>
> Repository: qpid
>
>
> Description
> -------
>
> For bug QPID-4872, I modified both the receive path and the send path in the transport code. Turns out only the send path is necessary - the original bug will not present on the receive path (checked the python code and openssl sources to confirm). The change to the receive path is actually less efficient as some versions of python merely implement recv_into by allocating a temp buffer and calling recv then doing a copy into the passed buffer!
>
> This change reverts the recv side of QPID-4872.
>
>
> Diffs
> -----
>
> /trunk/qpid/python/qpid/messaging/transports.py 1597595
>
> Diff: https://reviews.apache.org/r/21925/diff/
>
>
> Testing
> -------
>
> SSL unit tests.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 21925: QPID-5773: revert non-essential recv path change
from QPID-4872
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21925/
-----------------------------------------------------------
(Updated May 27, 2014, 1:20 p.m.)
Review request for qpid and Justin Ross.
Changes
-------
reloading original patch - reviewboard isn't making it available.
Bugs: qpid-5773
https://issues.apache.org/jira/browse/qpid-5773
Repository: qpid
Description
-------
For bug QPID-4872, I modified both the receive path and the send path in the transport code. Turns out only the send path is necessary - the original bug will not present on the receive path (checked the python code and openssl sources to confirm). The change to the receive path is actually less efficient as some versions of python merely implement recv_into by allocating a temp buffer and calling recv then doing a copy into the passed buffer!
This change reverts the recv side of QPID-4872.
Diffs (updated)
-----
/trunk/qpid/python/qpid/messaging/transports.py 1597595
Diff: https://reviews.apache.org/r/21925/diff/
Testing
-------
SSL unit tests.
Thanks,
Kenneth Giusti