You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by lresende <gi...@git.apache.org> on 2016/08/30 15:12:42 UTC
[GitHub] zeppelin pull request #1387: [ZEPPELIN-1398] Use relative path for search_da...
GitHub user lresende opened a pull request:
https://github.com/apache/zeppelin/pull/1387
[ZEPPELIN-1398] Use relative path for search_data.json
### What is this PR for?
Use relative path for search_data.json
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-1398](https://issues.apache.org/jira/browse/ZEPPELIN-1398)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lresende/incubator-zeppelin search
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1387
----
commit 0b63cdc1e609494c80e7d6eb3e7c37fd66135ae6
Author: Luciano Resende <lr...@apache.org>
Date: 2016-08-30T15:09:29Z
[ZEPPELIN-1398] Use relative path for search_data.json
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@AhyoungRyu we don't have any Selenium tests on the docs, so it should be unrelated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
All the issues are addressed i think.
IDK the exact reason, but some CI tests are failed with the below unrelated reason.
```
No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.
The build has been terminated
```
and in the Selenium test
```
INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Zeppelin: Interpreter .............................. SUCCESS [ 15.898 s]
[INFO] Zeppelin: Zengine .................................. SUCCESS [ 5.505 s]
[INFO] Zeppelin: Display system apis ...................... FAILURE [ 2.439 s]
[INFO] Zeppelin: Spark dependencies ....................... SKIPPED
[INFO] Zeppelin: Spark .................................... SKIPPED
[INFO] Zeppelin: Server ................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24.675 s
[INFO] Finished at: 2016-09-02T23:15:27+00:00
[INFO] Final Memory: 37M/419M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.scalatest:scalatest-maven-plugin:1.0:test (test) on project zeppelin-display_2.10: There are test failures -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :zeppelin-display_2.10
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@corneadoug I just wanna see the green light :)
I'm merging this one if there is no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/zeppelin/pull/1387
Thanks for checking @Leemoonsoo , I have followed your steps and provided an updated fix.
Here are the results on my local env.
<img width="1023" alt="zeppelin search" src="https://cloud.githubusercontent.com/assets/382917/18104477/1e74a43a-6eb0-11e6-8244-7b73ff26509f.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@lresende I fixed the another wrong path issue and pushed the patch to your Zeppelin repo. Could you check [https://github.com/lresende/incubator-zeppelin/pull/4](https://github.com/lresende/incubator-zeppelin/pull/4) out? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1387: [ZEPPELIN-1398] Use relative path for search_da...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@lresende Wow super fast! That was my bad. I should've thought about the relative path. Thank you for the quick fix and LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1387
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1387
Thanks @lresende for contribution.
I have tested this patch, but i still get the same error.
How to test
1) build `gh-pages` (website) branch
```
bundle exec jekyll build --safe
mv _site /tmp/zeppelin_website
```
2) build this patch (docs) and copy it under docs/0.7.0-SNAPSHOT of website
```
cd docs
bundle exec jekyll build --safe
mkdir /tmp/zeppelin-website/docs
mv _site /tmp/zeppelin_website/0.7.0-SNAPSHOT
```
3) start httpserver
```
cd /tmp/zeppelin_website
python -m SimpleHTTPServer
```
And browse localhost:8000, select 0.7.0-SNAPSHOT doc and try search
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@lresende Can you close and reopen this PR to re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1387
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1387: [ZEPPELIN-1398] Use relative path for search_data.json
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1387
@Leemoonsoo I tested and also checked the `search_data.json` issue has gone. But just noticed that the searched docs link has path problem as well. Let me configure out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---