[GitHub] [pulsar] merlimat commented on a change in pull request #13272: Align configurations defaults between default file and Java object (broker.conf, proxy.conf, websocket.conf)

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #13272:
URL: https://github.com/apache/pulsar/pull/13272#discussion_r767995482



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -933,7 +933,7 @@
     @FieldContext(
         category = CATEGORY_SERVER,
         doc = "Number of worker threads to serve non-persistent topic")
-    private int numWorkerThreadsForNonPersistentTopic = Runtime.getRuntime().availableProcessors();
+    private int numWorkerThreadsForNonPersistentTopic = 8;

Review comment:
       This is done to use the number of available core. We must not change it.

##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -576,7 +576,7 @@
         category = CATEGORY_POLICIES,
         doc = "How often is the thread pool scheduled to check whether a snapshot needs to be taken.(disable with value 0)"
     )
-    private int brokerDeduplicationSnapshotFrequencyInSeconds = 120;
+    private int brokerDeduplicationSnapshotFrequencyInSeconds = 10;

Review comment:
       10 seconds is too low. We should not change the 2 min




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org