You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2011/10/03 20:59:26 UTC
Re: Review Request: OOZIE-564 Embedded Pig within python
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2104/
-----------------------------------------------------------
(Updated 2011-10-03 18:59:26.298939)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Test cases added. Changes made in pom.xml for the test cases to work.
Review feedback incorporated
Summary
-------
OOZIE-564: Embedded pig within python fails when run in oozie
Summary:
https://issues.apache.org/jira/browse/OOZIE-564
This addresses bug OOZIE-564.
https://issues.apache.org/jira/browse/OOZIE-564
Diffs (updated)
-----
trunk/core/pom.xml 1178455
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1178455
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1178455
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1178455
trunk/pom.xml 1178455
Diff: https://reviews.apache.org/r/2104/diff
Testing
-------
Tested against current test cases. New test cases related to embedded pig are not added
Thanks,
Virag
Re: Review Request: OOZIE-564 Embedded Pig within python
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2104/#review2285
-----------------------------------------------------------
Overall, please take care of all the red marks for inconsistent spaces.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java
<https://reviews.apache.org/r/2104/#comment5264>
These python jars are not required for normal pig job. right?
If yes, can it be isolated only for python case?
- Mohammad
On 2011-10-03 18:59:26, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2104/
> -----------------------------------------------------------
>
> (Updated 2011-10-03 18:59:26)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-564: Embedded pig within python fails when run in oozie
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> This addresses bug OOZIE-564.
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> Diffs
> -----
>
> trunk/core/pom.xml 1178455
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1178455
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1178455
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1178455
> trunk/pom.xml 1178455
>
> Diff: https://reviews.apache.org/r/2104/diff
>
>
> Testing
> -------
>
> Tested against current test cases. New test cases related to embedded pig are not added
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-564 Embedded Pig within python
Posted by "Angelo K. Huang" <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2104/#review2286
-----------------------------------------------------------
release.log and documentation changes are missing.
trunk/core/pom.xml
<https://reviews.apache.org/r/2104/#comment5266>
Why and how these jars are being used?
Why only scope at 'test'?
trunk/core/pom.xml
<https://reviews.apache.org/r/2104/#comment5274>
space
trunk/core/pom.xml
<https://reviews.apache.org/r/2104/#comment5273>
space
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java
<https://reviews.apache.org/r/2104/#comment5267>
I saw you bump up version to 0.9. U might need to change it here.
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java
<https://reviews.apache.org/r/2104/#comment5268>
and here
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java
<https://reviews.apache.org/r/2104/#comment5271>
Does MainTestCase use only for Pig testing? If yes, please rename to proper name.
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java
<https://reviews.apache.org/r/2104/#comment5270>
use static
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java
<https://reviews.apache.org/r/2104/#comment5272>
space
trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java
<https://reviews.apache.org/r/2104/#comment5269>
The name of method should say what you are testing.
- Angelo K.
On 2011-10-03 18:59:26, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2104/
> -----------------------------------------------------------
>
> (Updated 2011-10-03 18:59:26)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-564: Embedded pig within python fails when run in oozie
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> This addresses bug OOZIE-564.
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> Diffs
> -----
>
> trunk/core/pom.xml 1178455
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1178455
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1178455
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1178455
> trunk/pom.xml 1178455
>
> Diff: https://reviews.apache.org/r/2104/diff
>
>
> Testing
> -------
>
> Tested against current test cases. New test cases related to embedded pig are not added
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-564 Embedded Pig within python
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2104/#review2333
-----------------------------------------------------------
Ship it!
pushing
- Mohammad
On 2011-10-04 01:27:24, Virag Kothari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2104/
> -----------------------------------------------------------
>
> (Updated 2011-10-04 01:27:24)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> OOZIE-564: Embedded pig within python fails when run in oozie
>
> Summary:
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> This addresses bug OOZIE-564.
> https://issues.apache.org/jira/browse/OOZIE-564
>
>
> Diffs
> -----
>
> trunk/core/pom.xml 1178455
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1178665
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1178659
> trunk/pom.xml 1178455
> trunk/release-log.txt 1178455
> trunk/sharelib/pom.xml 1178455
>
> Diff: https://reviews.apache.org/r/2104/diff
>
>
> Testing
> -------
>
> Tested against current test cases. New test cases related to embedded pig are not added
>
>
> Thanks,
>
> Virag
>
>
Re: Review Request: OOZIE-564 Embedded Pig within python
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2104/
-----------------------------------------------------------
(Updated 2011-10-04 01:27:24.173574)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Added jars in share-lib/pom.xml so available in system library.
Other changes made according to comments.
Summary
-------
OOZIE-564: Embedded pig within python fails when run in oozie
Summary:
https://issues.apache.org/jira/browse/OOZIE-564
This addresses bug OOZIE-564.
https://issues.apache.org/jira/browse/OOZIE-564
Diffs (updated)
-----
trunk/core/pom.xml 1178455
trunk/core/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 1178665
trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1178659
trunk/pom.xml 1178455
trunk/release-log.txt 1178455
trunk/sharelib/pom.xml 1178455
Diff: https://reviews.apache.org/r/2104/diff
Testing
-------
Tested against current test cases. New test cases related to embedded pig are not added
Thanks,
Virag