You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by conniey <gi...@git.apache.org> on 2016/11/12 21:26:51 UTC
[GitHub] lucenenet pull request #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
GitHub user conniey opened a pull request:
https://github.com/apache/lucenenet/pull/194
Updating from NUnit 2.6.3 to NUnit 3.5.0
Updates the current test projects to NUnit 3.5.0.
* Replaces obsolete `TestFixtureSetUp` and `TestFixtureTearDown` with `OneTimeSetUp` and `OneTimeTearDown`
* Replaces `[ExpectedException]` with `Assert.Throws<T>`
* Adds a reason for [Ignore] tests because it is required now
PR #191 depends on this because [dotnet-test-nunit ](https://github.com/nunit/dotnet-test-nunit) uses NUnit 3.5.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/conniey/lucenenet updateNUnit3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/194.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #194
----
commit ae1f6fd3305084eac90cbb98ed89ff698c933848
Author: Connie Yau <co...@microsoft.com>
Date: 2016-11-12T20:47:09Z
Updating test projects to NUnit 3.5.0
commit 8889dd6d200c17d8dffb086bc36c3388ac474639
Author: Connie Yau <co...@microsoft.com>
Date: 2016-10-31T06:34:43Z
Replacing obsolete [TestFixtureSetUp] with [OneTimeSetUp]
commit d2a26793d63894966d8c475abb6ccee7e092e7c7
Author: Connie Yau <co...@microsoft.com>
Date: 2016-10-31T05:34:49Z
Replacing [ExpectedException(T)] with Assert.Throws<T>
commit 0171a22f2527a0904bfdc43aebcb58797dfbc81f
Author: Connie Yau <co...@microsoft.com>
Date: 2016-10-31T06:33:36Z
Replacing obsolete [TestFixtureTearDown] with [OneTimeTearDown]
commit 9be007b70e810a2e96433560741fa90ab6a8c5fb
Author: Connie Yau <co...@microsoft.com>
Date: 2016-11-12T21:05:16Z
Adding Skip reason for [Ignore] tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by conniey <gi...@git.apache.org>.
Github user conniey commented on the issue:
https://github.com/apache/lucenenet/pull/194
@synhershko @NightOwl888 Is there anything I need to do to get this merged in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by NightOwl888 <gi...@git.apache.org>.
Github user NightOwl888 commented on the issue:
https://github.com/apache/lucenenet/pull/194
@synhershko
I reverted these commits because we already have this change in #191 and it causes a conflict, not to mention it breaks the build (see #200).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Ok, cool, merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Looks good to me, but seems like it's blocked by #191?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by conniey <gi...@git.apache.org>.
Github user conniey commented on the issue:
https://github.com/apache/lucenenet/pull/194
@synhershko @NightOwl888 When I had opened this PR, no one was working on my branch, so I was going to rebase my commits on top of this so there would be less changes to look at in #191. :) But since there is active development.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by conniey <gi...@git.apache.org>.
Github user conniey commented on the issue:
https://github.com/apache/lucenenet/pull/194
@synhershko This doesn't depend on #191. I created this PR off of master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet issue #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the issue:
https://github.com/apache/lucenenet/pull/194
Cool thanks - that's why I asked before merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request #194: Updating from NUnit 2.6.3 to NUnit 3.5.0
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---