You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/16 05:00:03 UTC
[GitHub] TisonKun opened a new pull request #6851: [FLINK-10559] Remove
LegacyLocalStreamEnvironment
TisonKun opened a new pull request #6851: [FLINK-10559] Remove LegacyLocalStreamEnvironment
URL: https://github.com/apache/flink/pull/6851
## What is the purpose of the change
Remove `LegacyLocalStreamEnvironment` which based on legacy mode and now we have its replacement `LocalStreamEnvironment`.
It looks like not just a simply removal because some previous miss or mistake.
1. `PythonEnvironmentFactory` still use `LegacyLocalStreamEnvironment`, which I believe is a missing task.
2. `LegacyLocalStreamEnvironment` is with annotation `@Public` by [this commit](https://github.com/apache/flink/commit/af5279e9bd3dec18512a54c59982e3dc1f253cd2). Of course `LocalStreamEnvironment` is `@Public` but `LegacyLocalStreamEnvironment` should never be.
## Brief change log
Remove `LegacyLocalStreamEnvironment.java`.
Replace `LegacyLocalStreamEnvironment` with `LocalStreamEnvironment` in `PythonEnvironmentFactory.java`, I believe it is a missing task.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `(Evolving)`: (**yes**, but I think it is because of a mistake.)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
cc @tillrohrmann @aljoscha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services