You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by ch...@awltux.com on 2014/04/28 22:05:14 UTC
How to submit a change for AntUnit?
Hi,
I realise the AntUnit project is pretty quiet, but I have a fix I'd
like to submit.
The LogCapturer currently concatenates all messages onto the same
line. Not very readable when you send the log to file.
I've added an EOL to each append in method:
LogCapturer.messageLogged(BuildEvent event)
How do I go about submitting this fix?
Regards,
Chris Holman
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by ch...@awltux.com.
Much appreciated Stefan.
It's a great tool; I wrote an ant script recently to auto build and
deploy oracle databases from an SVN repository. It was a monster of a
script and the AntUnit scripts I wrote for it were indispensable!
Regards,
Chris Holman
http://uk.linkedin.com/in/chrisdholman/
Quoting Stefan Bodewig <bo...@apache.org>:
> On 2014-04-29, <ch...@awltux.com> wrote:
>
>> Hi Stephan: nod of appreciation for AntUnit :-),
>
> Oh, many people have contributed.
>
>> Is the code base quiet because there are no further changes required,
>> or is there an alternative that I should use instead?
>
> Probably because it does what is needed by Ant itself and the antlibs
> that use AntUnit. There is one other issue raised against AntUnit that
> I wanted to look into anyway, but in general it is silent because nobody
> has an itch to scratch.
>
>> Being able to dump the logs is very handy when debugging the
>> tests/build scripts :-)
>
> ACK
>
>> If the LogCapturer was only intended to be used to assert against the
>> logs, the EOL shouldn't interfere with existing functionality (unless
>> the assert is checking for multi line log entries; which I suspect is
>> the exception to the rule).
>
> We can always try what happens to the Ant and Antlib builds. If I
> commit your patch then Gump will pick it up and use it - I don't expect
> there to be many other AntUnit users.
>
> Maybe we can introduce an option, though, I'l look into it soonish.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by Stefan Bodewig <bo...@apache.org>.
On 2014-04-29, <ch...@awltux.com> wrote:
> Hi Stephan: nod of appreciation for AntUnit :-),
Oh, many people have contributed.
> Is the code base quiet because there are no further changes required,
> or is there an alternative that I should use instead?
Probably because it does what is needed by Ant itself and the antlibs
that use AntUnit. There is one other issue raised against AntUnit that
I wanted to look into anyway, but in general it is silent because nobody
has an itch to scratch.
> Being able to dump the logs is very handy when debugging the
> tests/build scripts :-)
ACK
> If the LogCapturer was only intended to be used to assert against the
> logs, the EOL shouldn't interfere with existing functionality (unless
> the assert is checking for multi line log entries; which I suspect is
> the exception to the rule).
We can always try what happens to the Ant and Antlib builds. If I
commit your patch then Gump will pick it up and use it - I don't expect
there to be many other AntUnit users.
Maybe we can introduce an option, though, I'l look into it soonish.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by ch...@awltux.com.
Hi Stephan: nod of appreciation for AntUnit :-),
Is the code base quiet because there are no further changes required,
or is there an alternative that I should use instead?
Being able to dump the logs is very handy when debugging the
tests/build scripts :-)
If the LogCapturer was only intended to be used to assert against the
logs, the EOL shouldn't interfere with existing functionality (unless
the assert is checking for multi line log entries; which I suspect is
the exception to the rule).
Regards,
Chris Holman
http://uk.linkedin.com/in/chrisdholman/
Quoting Stefan Bodewig <bo...@apache.org>:
> On 2014-04-29, <ch...@awltux.com> wrote:
>
>> Good point on the rationale behind this functionality. Not sure what
>> reason there could be to have the log reported as a single line.
>> Though I can imagine existing scripts working round it by inserting
>> EOL characters at the end of an echo statement.
>
> It's been years since I last looked at the code :-)
>
> The resource really only is a side effect of having LogCapturer around
> and making asssertions on the log content - i.e. the newlines would only
> ever be noise for the assertion itself. AFAIR I never really thought of
> people printing the contents.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by Stefan Bodewig <bo...@apache.org>.
On 2014-04-29, <ch...@awltux.com> wrote:
> Good point on the rationale behind this functionality. Not sure what
> reason there could be to have the log reported as a single line.
> Though I can imagine existing scripts working round it by inserting
> EOL characters at the end of an echo statement.
It's been years since I last looked at the code :-)
The resource really only is a side effect of having LogCapturer around
and making asssertions on the log content - i.e. the newlines would only
ever be noise for the assertion itself. AFAIR I never really thought of
people printing the contents.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by ch...@awltux.com.
Thanks,
Good point on the rationale behind this functionality. Not sure what
reason there could be to have the log reported as a single line.
Though I can imagine existing scripts working round it by inserting
EOL characters at the end of an echo statement.
I've come across others that have trouble using this task to send the
logs to file.
I've created a bug to track the issue: 56470: AntUnits logcontent task
returns a one line log string
https://issues.apache.org/bugzilla/show_bug.cgi?id=56470
Regards,
Chris
Quoting Antoine Levy Lambert <an...@gmx.de>:
> Hello Chris,
>
> I wonder whether the current behavior of the LogCapturer has a
> rationale and whether a backward compatibility needs to be preserved
> for this aspect.
>
> To submit a patch, the best is to create a bugzilla issue on
> http://issues.apache.org/bugzilla and to attach
> the output of svn diff -u .
>
> Regards,
>
> Antoine
> On Apr 28, 2014, at 4:05 PM, chris.holman@awltux.com wrote:
>
>> Hi,
>>
>> I realise the AntUnit project is pretty quiet, but I have a fix I'd
>> like to submit.
>>
>> The LogCapturer currently concatenates all messages onto the same
>> line. Not very readable when you send the log to file.
>>
>> I've added an EOL to each append in method:
>> LogCapturer.messageLogged(BuildEvent event)
>>
>> How do I go about submitting this fix?
>>
>> Regards,
>> Chris Holman
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to submit a change for AntUnit?
Posted by Antoine Levy Lambert <an...@gmx.de>.
Hello Chris,
I wonder whether the current behavior of the LogCapturer has a rationale and whether a backward compatibility needs to be preserved for this aspect.
To submit a patch, the best is to create a bugzilla issue on http://issues.apache.org/bugzilla and to attach
the output of svn diff -u .
Regards,
Antoine
On Apr 28, 2014, at 4:05 PM, chris.holman@awltux.com wrote:
> Hi,
>
> I realise the AntUnit project is pretty quiet, but I have a fix I'd like to submit.
>
> The LogCapturer currently concatenates all messages onto the same line. Not very readable when you send the log to file.
>
> I've added an EOL to each append in method:
> LogCapturer.messageLogged(BuildEvent event)
>
> How do I go about submitting this fix?
>
> Regards,
> Chris Holman
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
AW: How to submit a change for AntUnit?
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
The process is the same as for Ant itself: create a bugzilla issue and
attach your patch.
Jan
> -----Ursprüngliche Nachricht-----
> Von: chris.holman@awltux.com [mailto:chris.holman@awltux.com]
> Gesendet: Montag, 28. April 2014 22:05
> An: dev@ant.apache.org
> Betreff: How to submit a change for AntUnit?
>
> Hi,
>
> I realise the AntUnit project is pretty quiet, but I have a fix I'd
> like to submit.
>
> The LogCapturer currently concatenates all messages onto the same line.
> Not very readable when you send the log to file.
>
> I've added an EOL to each append in method:
> LogCapturer.messageLogged(BuildEvent event)
>
> How do I go about submitting this fix?
>
> Regards,
> Chris Holman
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org For additional
> commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org