You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@aurora.apache.org by wi...@apache.org on 2014/08/06 18:12:28 UTC
git commit: Fix announcer test.
Repository: incubator-aurora
Updated Branches:
refs/heads/master a6e30ddd2 -> 77f4aa874
Fix announcer test.
Testing Done:
The announcer test does not fail on my laptop. But I predict what was
happening is that since I was just doing 2 clock.tick(1.0)s with the
ThreadedClock and the other end was doing a clock.sleep(2.0), there were no
guarantees that code was getting executed unless I did a subsequent
clock.tick(epsilon). I've instead just done clock.tick(> 2) to guarantee
that code executes.
Bugs closed: AURORA-638
Reviewed at https://reviews.apache.org/r/24359/
Project: http://git-wip-us.apache.org/repos/asf/incubator-aurora/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-aurora/commit/77f4aa87
Tree: http://git-wip-us.apache.org/repos/asf/incubator-aurora/tree/77f4aa87
Diff: http://git-wip-us.apache.org/repos/asf/incubator-aurora/diff/77f4aa87
Branch: refs/heads/master
Commit: 77f4aa874e4f74b9a06be851edd581bd0534da3e
Parents: a6e30dd
Author: Brian Wickman <wi...@apache.org>
Authored: Wed Aug 6 09:12:14 2014 -0700
Committer: Brian Wickman <wi...@apache.org>
Committed: Wed Aug 6 09:12:14 2014 -0700
----------------------------------------------------------------------
src/test/python/apache/aurora/executor/common/test_announcer.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-aurora/blob/77f4aa87/src/test/python/apache/aurora/executor/common/test_announcer.py
----------------------------------------------------------------------
diff --git a/src/test/python/apache/aurora/executor/common/test_announcer.py b/src/test/python/apache/aurora/executor/common/test_announcer.py
index e5c4ce4..df987b5 100644
--- a/src/test/python/apache/aurora/executor/common/test_announcer.py
+++ b/src/test/python/apache/aurora/executor/common/test_announcer.py
@@ -144,7 +144,7 @@ def test_announcer_on_expiration():
clock.tick(1.0)
assert announcer.disconnected_time() == 1.0, (
'Announcer should be disconnected on expiration.')
- clock.tick(1.0)
+ clock.tick(10.0)
assert announcer.disconnected_time() == 0.0, (
'Announcer should not advance disconnection time when connected.')
assert announcer._membership == 'membership 3'