You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2022/08/04 21:13:00 UTC
[jira] [Commented] (ARROW-17311) [C++] Vendor backward for better stack traces
[ https://issues.apache.org/jira/browse/ARROW-17311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17575453#comment-17575453 ]
Antoine Pitrou commented on ARROW-17311:
----------------------------------------
This was already discussed in ARROW-17093.
Personal summary: this is nice but unfortunately only dumps trace for the currently executing thread, making it of limited use for the most interesting cases (e.g. sporadic crashes on CI due to MT issues).
> [C++] Vendor backward for better stack traces
> ---------------------------------------------
>
> Key: ARROW-17311
> URL: https://issues.apache.org/jira/browse/ARROW-17311
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Ben Kietzman
> Priority: Major
>
> [https://github.com/bombela/backward-cpp] is a neat single-header library which allows capture of very expressive stack traces. It is compatible with c++11 and is cross platform, I think it would greatly improve error reporting in arrow.
> !https://raw.githubusercontent.com/bombela/backward-cpp/master/doc/pretty.png!
> In particular, the stack traces provided by a failed DCHECK are much less expressive than they could be and don't include file/line information, while the traces added to statuses by {{ARROW_EXTRA_ERROR_CONTEXT}} don't include the frame in which the status was constructed- which is frequently the frame which we most need information from. Backward addresses these shortcomings and then some.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)