You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2019/04/12 15:16:11 UTC

[lucene-solr] branch branch_8x updated: SOLR-13366: Clarify 'Invalid stage name' warning logging in AutoScalingConfig

This is an automated email from the ASF dual-hosted git repository.

cpoerschke pushed a commit to branch branch_8x
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/branch_8x by this push:
     new cae3236  SOLR-13366: Clarify 'Invalid stage name' warning logging in AutoScalingConfig
cae3236 is described below

commit cae323629e437c47855c4c8578f76310fd2b7b84
Author: Christine Poerschke <cp...@apache.org>
AuthorDate: Fri Apr 12 16:01:55 2019 +0100

    SOLR-13366: Clarify 'Invalid stage name' warning logging in AutoScalingConfig
---
 solr/CHANGES.txt                                                       | 2 ++
 solr/solr-ref-guide/src/solrcloud-autoscaling-listeners.adoc           | 2 +-
 .../apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java  | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index bd24d0d..a47312e 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -223,6 +223,8 @@ Other Changes
 
 * SOLR-12809: Document recommended Java/Solr combinations (Erick Erickson, Jan Høydahl et.al.)
 
+* SOLR-13366: Clarify 'Invalid stage name' warning logging in AutoScalingConfig (Christine Poerschke)
+
 ==================  8.0.0 ==================
 
 Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release.
diff --git a/solr/solr-ref-guide/src/solrcloud-autoscaling-listeners.adoc b/solr/solr-ref-guide/src/solrcloud-autoscaling-listeners.adoc
index f3cc02d..6e6bfca 100644
--- a/solr/solr-ref-guide/src/solrcloud-autoscaling-listeners.adoc
+++ b/solr/solr-ref-guide/src/solrcloud-autoscaling-listeners.adoc
@@ -155,7 +155,7 @@ trigger named `foo`):
 {
  "name" : "foo.system",
  "trigger" : "solr.SystemLogListener",
- "stage" : ["WAITING", "STARTED", "ABORTED", "SUCCEEDED", "FAILED", "BEFORE_ACTION", "AFTER_ACTION"]
+ "stage" : ["STARTED", "ABORTED", "SUCCEEDED", "FAILED", "BEFORE_ACTION", "AFTER_ACTION"]
 }
 ----
 
diff --git a/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java b/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
index 14cb884..366b891 100644
--- a/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
+++ b/solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/AutoScalingConfig.java
@@ -81,7 +81,8 @@ public class AutoScalingConfig implements MapWriter {
           TriggerEventProcessorStage stage = TriggerEventProcessorStage.valueOf(String.valueOf(stageName).toUpperCase(Locale.ROOT));
           stages.add(stage);
         } catch (Exception e) {
-          log.warn("Invalid stage name '" + name + "' in listener config, skipping: " + properties);
+          log.warn("Invalid stage name '{}' for '{}' in listener config, skipping it in: {}",
+              stageName, name, properties);
         }
       }
       listenerClass = (String)this.properties.get(AutoScalingParams.CLASS);