You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Gacko <gi...@git.apache.org> on 2017/02/26 19:16:01 UTC

[GitHub] kafka pull request #2600: KAFKA-4806: Prevent double logging of ConsumerConf...

GitHub user Gacko opened a pull request:

    https://github.com/apache/kafka/pull/2600

    KAFKA-4806: Prevent double logging of ConsumerConfig.

    The consumer properties get logged twice since two instances of ConsumerConfig are created during creation of KafkaConsumer.
    
    I added a constructor of ConsumerConfig accepting the boolean parameter doLog which is already passable in AbstractConfig and set it to false during the second ConsumerConfig creating in the KafkaConsumer constructor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Gacko/kafka trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2600
    
----
commit e51683bd171bbd6288f21615e3c1fba3f1c9e454
Author: Marco Ebert <ma...@icloud.com>
Date:   2017-02-26T19:10:37Z

    KAFKA-4806: Prevent double logging of ConsumerConfig by adding constructor with doLog parameter.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2600: KAFKA-4806: Prevent double logging of ConsumerConf...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2600


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---