You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/06/07 15:12:00 UTC

[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability

     [ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=779145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779145 ]

ASF GitHub Bot logged work on HDFS-16625:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/22 15:11
            Start Date: 07/Jun/22 15:11
    Worklog Time Spent: 10m 
      Work Description: snmvaughan opened a new pull request, #4414:
URL: https://github.com/apache/hadoop/pull/4414

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   There are unit tests that require native PMDK libraries which aren't checking if the library is available, resulting in unsuccessful test.  This patch checks the assumption about PMDK availability.  The same changes have been applied and tested against trunk (3.4.0-SNAPSHOT), branch-3.3 (3.3.4-SNAPSHOT), and branch-3.3.3.
   
   ### How was this patch tested?
   
   This patch has been applied to a local build that runs in the Hadoop development environment, which doesn't include the PMDK shared libraries.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 779145)
    Remaining Estimate: 0h
            Time Spent: 10m

> Unit tests aren't checking for PMDK availability
> ------------------------------------------------
>
>                 Key: HDFS-16625
>                 URL: https://issues.apache.org/jira/browse/HDFS-16625
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 3.4.0, 3.3.4
>            Reporter: Steve Vaughan
>            Priority: Blocker
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are unit tests that require native PMDK libraries which aren't checking if the library is available, resulting in unsuccessful test.  Adding the following in the test setup addresses the problem.
> {code:java}
> assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org