You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "swuferhong (via GitHub)" <gi...@apache.org> on 2023/02/02 08:28:18 UTC
[GitHub] [flink] swuferhong opened a new pull request, #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
swuferhong opened a new pull request, #21828:
URL: https://github.com/apache/flink/pull/21828
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Now, ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode. This may cause error while creating StreamGraph for BatchExecMultiInput due to different id of rootNode and inputNode. This pr is aims to fix this error.
## Brief change log
- Change the visit method in `ResetTransformationProcessor`
- Add test `ResetTransformationProcessorTest`
## Verifying this change
- Add test `ResetTransformationProcessorTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] swuferhong commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1095486586
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java:
##########
@@ -102,11 +98,7 @@ public void testNonChainableTableSource() throws IOException {
private void assertChainableSource(String name, TableTestUtil util, boolean expected) {
String sql = "SELECT * FROM " + name;
Table table = util.tableEnv().sqlQuery(sql);
Review Comment:
> nit: this line can be removed
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] swuferhong commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1095266434
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/ResetTransformationProcessorTest.java:
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.processor;
+
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraphGenerator;
+import org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecMultipleInput;
+import org.apache.flink.table.planner.plan.nodes.exec.visitor.AbstractExecNodeExactlyOnceVisitor;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.table.planner.utils.BatchTableTestUtil;
+import org.apache.flink.table.planner.utils.TableTestBase;
+import org.apache.flink.table.planner.utils.TableTestUtil;
+
+import org.apache.calcite.rel.RelNode;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.Collections;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/** Tests for {@link ResetTransformationProcessor}. */
+public class ResetTransformationProcessorTest extends TableTestBase {
+
+ private BatchTableTestUtil util;
+ private TableEnvironment tEnv;
+
+ @Before
+ public void begin() {
+ util = batchTestUtil(TableConfig.getDefault());
+ tEnv = util.tableEnv();
+
+ tEnv.executeSql(
+ "CREATE TABLE Source1 (\n"
+ + " a BIGINT,\n"
+ + " b BIGINT,\n"
+ + " c VARCHAR,\n"
+ + " d BIGINT\n"
+ + ") WITH (\n"
+ + " 'connector' = 'values',\n"
+ + " 'bounded' = 'true'\n"
+ + ")");
+
+ tEnv.executeSql(
+ "CREATE TABLE Source2 (\n"
+ + " a BIGINT,\n"
+ + " b BIGINT,\n"
+ + " c VARCHAR,\n"
+ + " d BIGINT\n"
+ + ") WITH (\n"
+ + " 'connector' = 'values',\n"
+ + " 'bounded' = 'true'\n"
+ + ")");
+ }
+
+ @Test
+ public void testResetTransformation() {
+ String query = "SELECT * FROM Source1 WHERE a > 100";
+ ExecNodeGraph execNodeGraph = createExecNodeGraph(query);
+ execNodeGraph.getRootNodes().forEach(node -> node.translateToPlan(util.getPlanner()));
+ assertAllTransformationsIsNotNull(execNodeGraph);
+
+ ResetTransformationProcessor resetTransformationProcessor =
+ new ResetTransformationProcessor();
+ resetTransformationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ assertAllTransformationsIsNull(execNodeGraph);
+ }
+
+ @Test
+ public void testResetTransformationWithExecMultipleInputInExecGraph() {
+ String query =
+ "SELECT Source1.a FROM Source1, Source2 "
+ + "WHERE Source1.a = Source2.a AND Source2.a = (SELECT Source2.a FROM Source2 WHERE b > 100)";
+ ExecNodeGraph execNodeGraph = createExecNodeGraph(query);
+
+ MultipleInputNodeCreationProcessor multipleInputNodeCreationProcessor =
+ new MultipleInputNodeCreationProcessor(false);
+ multipleInputNodeCreationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ execNodeGraph.getRootNodes().forEach(node -> node.translateToPlan(util.getPlanner()));
+ assertAllTransformationsIsNotNull(execNodeGraph);
+
+ // If execNodeGraph include batchExecMultipleInput node. The ResetTransformationProcessor
+ // need to both set the transformation in each execNode and the transformation in
+ // batchExecMultipleInput.rootNode to null.
+ ResetTransformationProcessor resetTransformationProcessor =
+ new ResetTransformationProcessor();
+ resetTransformationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ assertAllTransformationsIsNull(execNodeGraph);
+ }
+
+ private ExecNodeGraph createExecNodeGraph(String query) {
+ Table table = tEnv.sqlQuery(query);
+ RelNode relNode = TableTestUtil.toRelNode(table);
+ FlinkPhysicalRel optimizedRel = (FlinkPhysicalRel) util.getPlanner().optimize(relNode);
+ ExecNodeGraphGenerator generator = new ExecNodeGraphGenerator();
+ return generator.generate(Collections.singletonList(optimizedRel), false);
+ }
Review Comment:
> extract a method into `TableTestUtilBase` and refactor MultipleInputNodeCreationProcessorTest#assertChainableSource
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21828:
URL: https://github.com/apache/flink/pull/21828#issuecomment-1413342532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0ca103fede681e20c68d7c19d2b0a4542e55a725",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ca103fede681e20c68d7c19d2b0a4542e55a725",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0ca103fede681e20c68d7c19d2b0a4542e55a725 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "godfreyhe (via GitHub)" <gi...@apache.org>.
godfreyhe closed pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
URL: https://github.com/apache/flink/pull/21828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "godfreyhe (via GitHub)" <gi...@apache.org>.
godfreyhe commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1095421034
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java:
##########
@@ -102,11 +98,7 @@ public void testNonChainableTableSource() throws IOException {
private void assertChainableSource(String name, TableTestUtil util, boolean expected) {
String sql = "SELECT * FROM " + name;
Table table = util.tableEnv().sqlQuery(sql);
Review Comment:
nit: this line can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "godfreyhe (via GitHub)" <gi...@apache.org>.
godfreyhe commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1094439449
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java:
##########
@@ -276,4 +277,9 @@ protected String createFormattedTransformationName(
public void resetTransformation() {
this.transformation = null;
}
+
+ @VisibleForTesting
+ public boolean isTransformationNull() {
Review Comment:
just provide getTransformation method for testing
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/ResetTransformationProcessorTest.java:
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.processor;
+
+import org.apache.flink.table.api.Table;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraphGenerator;
+import org.apache.flink.table.planner.plan.nodes.exec.batch.BatchExecMultipleInput;
+import org.apache.flink.table.planner.plan.nodes.exec.visitor.AbstractExecNodeExactlyOnceVisitor;
+import org.apache.flink.table.planner.plan.nodes.physical.FlinkPhysicalRel;
+import org.apache.flink.table.planner.utils.BatchTableTestUtil;
+import org.apache.flink.table.planner.utils.TableTestBase;
+import org.apache.flink.table.planner.utils.TableTestUtil;
+
+import org.apache.calcite.rel.RelNode;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.Collections;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/** Tests for {@link ResetTransformationProcessor}. */
+public class ResetTransformationProcessorTest extends TableTestBase {
+
+ private BatchTableTestUtil util;
+ private TableEnvironment tEnv;
+
+ @Before
+ public void begin() {
+ util = batchTestUtil(TableConfig.getDefault());
+ tEnv = util.tableEnv();
+
+ tEnv.executeSql(
+ "CREATE TABLE Source1 (\n"
+ + " a BIGINT,\n"
+ + " b BIGINT,\n"
+ + " c VARCHAR,\n"
+ + " d BIGINT\n"
+ + ") WITH (\n"
+ + " 'connector' = 'values',\n"
+ + " 'bounded' = 'true'\n"
+ + ")");
+
+ tEnv.executeSql(
+ "CREATE TABLE Source2 (\n"
+ + " a BIGINT,\n"
+ + " b BIGINT,\n"
+ + " c VARCHAR,\n"
+ + " d BIGINT\n"
+ + ") WITH (\n"
+ + " 'connector' = 'values',\n"
+ + " 'bounded' = 'true'\n"
+ + ")");
+ }
+
+ @Test
+ public void testResetTransformation() {
+ String query = "SELECT * FROM Source1 WHERE a > 100";
+ ExecNodeGraph execNodeGraph = createExecNodeGraph(query);
+ execNodeGraph.getRootNodes().forEach(node -> node.translateToPlan(util.getPlanner()));
+ assertAllTransformationsIsNotNull(execNodeGraph);
+
+ ResetTransformationProcessor resetTransformationProcessor =
+ new ResetTransformationProcessor();
+ resetTransformationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ assertAllTransformationsIsNull(execNodeGraph);
+ }
+
+ @Test
+ public void testResetTransformationWithExecMultipleInputInExecGraph() {
+ String query =
+ "SELECT Source1.a FROM Source1, Source2 "
+ + "WHERE Source1.a = Source2.a AND Source2.a = (SELECT Source2.a FROM Source2 WHERE b > 100)";
+ ExecNodeGraph execNodeGraph = createExecNodeGraph(query);
+
+ MultipleInputNodeCreationProcessor multipleInputNodeCreationProcessor =
+ new MultipleInputNodeCreationProcessor(false);
+ multipleInputNodeCreationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ execNodeGraph.getRootNodes().forEach(node -> node.translateToPlan(util.getPlanner()));
+ assertAllTransformationsIsNotNull(execNodeGraph);
+
+ // If execNodeGraph include batchExecMultipleInput node. The ResetTransformationProcessor
+ // need to both set the transformation in each execNode and the transformation in
+ // batchExecMultipleInput.rootNode to null.
+ ResetTransformationProcessor resetTransformationProcessor =
+ new ResetTransformationProcessor();
+ resetTransformationProcessor.process(
+ execNodeGraph, new ProcessorContext(util.getPlanner()));
+ assertAllTransformationsIsNull(execNodeGraph);
+ }
+
+ private ExecNodeGraph createExecNodeGraph(String query) {
+ Table table = tEnv.sqlQuery(query);
+ RelNode relNode = TableTestUtil.toRelNode(table);
+ FlinkPhysicalRel optimizedRel = (FlinkPhysicalRel) util.getPlanner().optimize(relNode);
+ ExecNodeGraphGenerator generator = new ExecNodeGraphGenerator();
+ return generator.generate(Collections.singletonList(optimizedRel), false);
+ }
Review Comment:
extract a method into `TableTestUtilBase` and refactor MultipleInputNodeCreationProcessorTest#assertChainableSource
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMultipleInput.java:
##########
@@ -152,4 +152,8 @@ protected Transformation<RowData> translateToPlanInternal(
public List<ExecEdge> getOriginalEdges() {
return originalEdges;
}
+
+ public ExecNode<?> getRootNode() {
Review Comment:
just need override `resetTransformation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] swuferhong commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1095266250
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java:
##########
@@ -276,4 +277,9 @@ protected String createFormattedTransformationName(
public void resetTransformation() {
this.transformation = null;
}
+
+ @VisibleForTesting
+ public boolean isTransformationNull() {
Review Comment:
> just provide getTransformation method for testing
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] swuferhong commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on code in PR #21828:
URL: https://github.com/apache/flink/pull/21828#discussion_r1095266326
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMultipleInput.java:
##########
@@ -152,4 +152,8 @@ protected Transformation<RowData> translateToPlanInternal(
public List<ExecEdge> getOriginalEdges() {
return originalEdges;
}
+
+ public ExecNode<?> getRootNode() {
Review Comment:
> just need override `resetTransformation`
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] swuferhong commented on pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.rootNode
Posted by "swuferhong (via GitHub)" <gi...@apache.org>.
swuferhong commented on PR #21828:
URL: https://github.com/apache/flink/pull/21828#issuecomment-1415368421
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org