You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Adam (Created) (JIRA)" <ji...@apache.org> on 2011/10/17 14:51:10 UTC

[jira] [Created] (TAP5-1700) The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore

The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore
------------------------------------------------------------------------------

                 Key: TAP5-1700
                 URL: https://issues.apache.org/jira/browse/TAP5-1700
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3
            Reporter: Adam


In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.

In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.

This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134221#comment-13134221 ] 

Hudson commented on TAP5-1700:
------------------------------

Integrated in tapestry-trunk-freestyle #602 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/602/])
    TAP5-1700: Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188198
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java

                
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1700) The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore

Posted by "Howard M. Lewis Ship (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1700:
------------------------------------------

    Assignee: Howard M. Lewis Ship
    
> The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore
> ------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1700:
---------------------------------------

    Summary: Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form  (was: The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore)
    
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134221#comment-13134221 ] 

Hudson commented on TAP5-1700:
------------------------------

Integrated in tapestry-trunk-freestyle #602 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/602/])
    TAP5-1700: Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

hlship : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1188198
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/corelib/components/FormInjector.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ajax/AjaxResponseRendererImpl.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/services/ajax/AjaxResponseRenderer.java

                
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1700.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
    
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Howard M. Lewis Ship (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-1700:
---------------------------------------

    Summary: Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form  (was: The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore)
    
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1700) The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore

Posted by "Howard M. Lewis Ship (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAP5-1700:
------------------------------------------

    Assignee: Howard M. Lewis Ship
    
> The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore
> ------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1700) Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form

Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1700.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3
    
> Changes to partial markup rendering mean that the critical elementId JSON key is no longer set in the response when injecting content into a Form
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.3
>
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1700) The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore

Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam updated TAP5-1700:
-----------------------

    Attachment: forminjector53.txt

Here's a patch that adds the filter to the queue before calling triggerEvent.
                
> The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore
> ------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1700) The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore

Posted by "Adam (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam updated TAP5-1700:
-----------------------

    Attachment: forminjector53.txt

Here's a patch that adds the filter to the queue before calling triggerEvent.
                
> The PartialMarkupRendererFilter in FormInjector.onInject is not called anymore
> ------------------------------------------------------------------------------
>
>                 Key: TAP5-1700
>                 URL: https://issues.apache.org/jira/browse/TAP5-1700
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Adam
>         Attachments: forminjector53.txt
>
>
> In 5.2.6, the Block returned by other components' onAction events triggered by onInject does not get rendered right away, giving onInject a chance to add another PartialMarkupRendererFilter.
> In 5.3, the filters are called shortly after the Block is returned from onAction, before the triggerContextEvent call in onInject returns. The filter added afterwards is not called.
> This results in the elements returned by FormInjector during ajax requests not having ids assigned to them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira