You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/16 07:03:40 UTC
Review Request 24767: Validate Docker version since we require >=
1.0.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24767/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/docker/docker.cpp a4bad5b41765fdbcc9a748d5a3153700fbc1fc80
Diff: https://reviews.apache.org/r/24767/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 24767: Validate Docker version since we require >=
1.0.0.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Aug. 16, 2014, 5:13 a.m., Timothy Chen wrote:
> > src/docker/docker.cpp, line 137
> > <https://reviews.apache.org/r/24767/diff/1/?file=662013#file662013line137>
> >
> > I think we can use this as validation and remove calling docker info above.
Yeah, great idea!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24767/#review50816
-----------------------------------------------------------
On Aug. 16, 2014, 5:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24767/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 5:03 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp a4bad5b41765fdbcc9a748d5a3153700fbc1fc80
>
> Diff: https://reviews.apache.org/r/24767/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24767: Validate Docker version since we require >=
1.0.0.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24767/#review50816
-----------------------------------------------------------
src/docker/docker.cpp
<https://reviews.apache.org/r/24767/#comment88677>
I think we can use this as validation and remove calling docker info above.
- Timothy Chen
On Aug. 16, 2014, 5:03 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24767/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 5:03 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp a4bad5b41765fdbcc9a748d5a3153700fbc1fc80
>
> Diff: https://reviews.apache.org/r/24767/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24767: Validate Docker version since we require >=
1.0.0.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24767/#review50824
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 16, 2014, 2:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24767/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2014, 2:58 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp a4bad5b41765fdbcc9a748d5a3153700fbc1fc80
>
> Diff: https://reviews.apache.org/r/24767/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24767: Validate Docker version since we require >=
1.0.0.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24767/
-----------------------------------------------------------
(Updated Aug. 16, 2014, 2:58 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/docker/docker.cpp a4bad5b41765fdbcc9a748d5a3153700fbc1fc80
Diff: https://reviews.apache.org/r/24767/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman