You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/04 11:22:18 UTC
[GitHub] [spark] saikocat opened a new pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
saikocat opened a new pull request #31473:
URL: https://github.com/apache/spark/pull/31473
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Due to user-experience (confusing to Spark users - java.sql.Time using milliseconds vs Spark using microseconds; and user losing useful functions like hour(), minute(), etc on the column), we have decided to revert back to use TimestampType but this time we will enforce the hour to be consistently across system timezone (via offset manipulation) and date part fixed to zero epoch.
Full Discussion with Wenchen Fan Wenchen Fan regarding this ticket is here https://github.com/apache/spark/pull/30902#discussion_r569186823
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Revert and improvement to sql.Time handling
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests and integration tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773235806
CC: @cloud-fan @sarutak @skestle - regarding the updated changes to respect vendor db integrations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773489316
**[Test build #134878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134878/testReport)** for PR 31473 at commit [`0b4a344`](https://github.com/apache/spark/commit/0b4a344674cddedca40790869a739f07208c7be0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773499543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134878/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31473:
URL: https://github.com/apache/spark/pull/31473#discussion_r570204612
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
Review comment:
In most cases, session timezone should be the same as JVM default timezone, but ideally we should use session timezone for datetime operations: `SQLConf.get.sessionLocalTimeZone`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
+ case zoneInfo: ZoneInfo => zoneInfo.getOffsetsByWall(localTimeMillis, null)
+ case timeZone: TimeZone => timeZone.getOffset(localTimeMillis - timeZone.getRawOffset)
+ }
Review comment:
Seems we can just do `DateTimeUtils.toUTCTime(localTimeMicro, SQLConf.get.sessionLocalTimeZone)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773324845
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39458/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773374305
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39458/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773411458
**[Test build #134872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134872/testReport)** for PR 31473 at commit [`15e980f`](https://github.com/apache/spark/commit/15e980feffe7f3bd03fb6922a87173f19ab08fba).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` assert(types(1).equals(\"class java.sql.Timestamp\"))`
* ` assert(types(5).equals(\"class java.sql.Timestamp\"))`
* ` assert(types(1).equals(\"class java.sql.Timestamp\"))`
* ` assert(types(2).equals(\"class java.sql.Timestamp\"))`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773397100
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773264767
ok to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773342160
Confirmed all the JDBC integration tests pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773342160
Confirmed all the JDBC integration tests pass for the latest commit 0b4a344.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773417125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134872/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773357763
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39458/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773268380
@saikocat Have you confirmed all the integration tests like `PostgresIntegrationSuite` passes?
Jenkins and GA don't run them so we need to confirm by ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773268380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773397100
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31473:
URL: https://github.com/apache/spark/pull/31473#discussion_r570204612
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
Review comment:
In most cases, session timezone should be the same as JVM default timezone, but ideally we should use session timezone for datetime operations: `SQLConf.get.sessionLocalTimeZone`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat commented on a change in pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat commented on a change in pull request #31473:
URL: https://github.com/apache/spark/pull/31473#discussion_r570218581
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
+ case zoneInfo: ZoneInfo => zoneInfo.getOffsetsByWall(localTimeMillis, null)
+ case timeZone: TimeZone => timeZone.getOffset(localTimeMillis - timeZone.getRawOffset)
+ }
Review comment:
Superb! This is really more elegant. Thanks for this suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773470315
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773374305
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39458/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773376869
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773285978
> Yup, I learned from my previous mistake. All IT all passed.
>
> Edit: manual loaded the docker image for mssql works
Thanks. Anyway, I'll run all the integration tests before this change merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat edited a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat edited a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773280147
> @saikocat Have you confirmed all the integration tests like `PostgresIntegrationSuite` pass?
> Jenkins and GA don't run them so we need to confirm by ourselves.
Yup, I learned from my previous mistake. All IT all passed.
Edit: manual loaded the docker image for mssql works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773388308
**[Test build #134878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134878/testReport)** for PR 31473 at commit [`0b4a344`](https://github.com/apache/spark/commit/0b4a344674cddedca40790869a739f07208c7be0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31473:
URL: https://github.com/apache/spark/pull/31473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773280147
> @saikocat Have you confirmed all the integration tests like `PostgresIntegrationSuite` pass?
> Jenkins and GA don't run them so we need to confirm by ourselves.
Yup, I learned from my previous mistake. Though for mssql, I couldn't run it at all due to images not available/access denied (both GA and latest) :< the rest IT all passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
**[Test build #134872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134872/testReport)** for PR 31473 at commit [`15e980f`](https://github.com/apache/spark/commit/15e980feffe7f3bd03fb6922a87173f19ab08fba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773388308
**[Test build #134878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134878/testReport)** for PR 31473 at commit [`0b4a344`](https://github.com/apache/spark/commit/0b4a344674cddedca40790869a739f07208c7be0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31473:
URL: https://github.com/apache/spark/pull/31473#discussion_r570206549
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
+ case zoneInfo: ZoneInfo => zoneInfo.getOffsetsByWall(localTimeMillis, null)
+ case timeZone: TimeZone => timeZone.getOffset(localTimeMillis - timeZone.getRawOffset)
+ }
Review comment:
Seems we can just do `DateTimeUtils.toUTCTime(localTimeMicro, SQLConf.get.sessionLocalTimeZone)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773268380
@saikocat Have you confirmed all the integration tests like `PostgresIntegrationSuite` pass?
Jenkins and GA don't run them so we need to confirm by ourselves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773306832
**[Test build #134872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134872/testReport)** for PR 31473 at commit [`15e980f`](https://github.com/apache/spark/commit/15e980feffe7f3bd03fb6922a87173f19ab08fba).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773499543
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134878/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773235806
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat edited a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat edited a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773280147
> @saikocat Have you confirmed all the integration tests like `PostgresIntegrationSuite` pass?
> Jenkins and GA don't run them so we need to confirm by ourselves.
Yup, I learned from my previous mistake. All IT all passed.
Edit: manual loaded the docker image for mssql works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773417125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134872/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] saikocat commented on a change in pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
saikocat commented on a change in pull request #31473:
URL: https://github.com/apache/spark/pull/31473#discussion_r570218581
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -470,6 +455,27 @@ object JdbcUtils extends Logging {
// TODO(davies): use getBytes for better performance, if the encoding is UTF-8
row.update(pos, UTF8String.fromString(rs.getString(pos + 1)))
+ // SPARK-34357 - sql TIME type represents as zero epoch timestamp.
+ // It is represented as Spark TimestampType but fixed at 1970-01-01 for day,
+ // time portion is time of day, with no reference to a particular calendar,
+ // time zone or date, with a precision till microseconds.
+ // It stores the number of milliseconds after midnight, 00:00:00.000000
+ case TimestampType if metadata.contains("logical_time_type") =>
+ (rs: ResultSet, row: InternalRow, pos: Int) => {
+ val rawTime = rs.getTime(pos + 1)
+ if (rawTime != null) {
+ val localTimeMicro = TimeUnit.NANOSECONDS.toMicros(rawTime.toLocalTime().toNanoOfDay())
+ val localTimeMillis = DateTimeUtils.microsToMillis(localTimeMicro)
+ val timeZoneOffset = TimeZone.getDefault match {
+ case zoneInfo: ZoneInfo => zoneInfo.getOffsetsByWall(localTimeMillis, null)
+ case timeZone: TimeZone => timeZone.getOffset(localTimeMillis - timeZone.getRawOffset)
+ }
Review comment:
Superb! This is really more elegant. Thanks for this suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773470315
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #31473: [SPARK-34357] Revert JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773264767
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773256704
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31473:
URL: https://github.com/apache/spark/pull/31473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31473: [SPARK-34357][SQL] Map JDBC SQL TIME type to TimestampType with time portion fixed regardless of timezone
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31473:
URL: https://github.com/apache/spark/pull/31473#issuecomment-773396811
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39461/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org