Is it mandatory to create a bug to submit a patch (minor spell changes in the code comments)

[Raghavendran N <ra...@gmail.com>]

Team,
Is it mandatory to create a bug to submit a patch? I have made a very minor
change (corrected a sentence in a comment) towards my first patch.
Best regards,
-raghav

Re: Is it mandatory to create a bug to submit a patch (minor spell changes in the code comments)

[Raghavendran N <ra...@gmail.com>]

Thank you Mark. I will send the patch in a separate email to this list.
-raghav

On Mon, Mar 16, 2015 at 3:00 PM, Mark Thomas <ma...@apache.org> wrote:

> On 16/03/2015 03:42, Raghavendran N wrote:
> > Team,
> > Is it mandatory to create a bug to submit a patch?
>
> No. Very simple patches can be posted in-line (in diff-u format) in an
> e-mail to the dev list. Note that if it isn't picked up straight away
> (the same day) then there is a risk that it gets forgotten.
>
> We also accept patches via github pull requests.
>
> The advantage of creating a Bugzilla entry is that the patch won't get
> forgotten. Not that isn't the same as the patch being acted on instantly.
>
> > I have made a very minor
> > change (corrected a sentence in a comment) towards my first patch.
>
> For trivial patches (no more than a couple of lines), I'd suggest just
> sending them in-line to this list. Anything bigger than that should have
> a bugzilla entry.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: Is it mandatory to create a bug to submit a patch (minor spell changes in the code comments)

[Konstantin Kolinko <kn...@gmail.com>]

2015-03-16 12:30 GMT+03:00 Mark Thomas <ma...@apache.org>:
> On 16/03/2015 03:42, Raghavendran N wrote:
>> Team,
>> Is it mandatory to create a bug to submit a patch?
>
> No. Very simple patches can be posted in-line (in diff-u format) in an
> e-mail to the dev list. Note that if it isn't picked up straight away
> (the same day) then there is a risk that it gets forgotten.
>
> We also accept patches via github pull requests.
>
> The advantage of creating a Bugzilla entry is that the patch won't get
> forgotten. Not that isn't the same as the patch being acted on instantly.
>
>> I have made a very minor
>> change (corrected a sentence in a comment) towards my first patch.
>
> For trivial patches (no more than a couple of lines), I'd suggest just
> sending them in-line to this list. Anything bigger than that should have
> a bugzilla entry.
>


1. If something deserves a line in changelog, it is better to create
an issue in Bugzilla.

Try to read the changelog by yourself.  Items that do not have a
bugzilla number are harder to follow.

I think that pull requests need a bugzilla entry as well.

2. Mailing list rules:
http://tomcat.apache.org/lists.html#tomcat-users
- No attachments
- Do not top-post.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Is it mandatory to create a bug to submit a patch (minor spell changes in the code comments)

[Mark Thomas <ma...@apache.org>]

On 16/03/2015 03:42, Raghavendran N wrote:
> Team,
> Is it mandatory to create a bug to submit a patch?

No. Very simple patches can be posted in-line (in diff-u format) in an
e-mail to the dev list. Note that if it isn't picked up straight away
(the same day) then there is a risk that it gets forgotten.

We also accept patches via github pull requests.

The advantage of creating a Bugzilla entry is that the patch won't get
forgotten. Not that isn't the same as the patch being acted on instantly.

> I have made a very minor
> change (corrected a sentence in a comment) towards my first patch.

For trivial patches (no more than a couple of lines), I'd suggest just
sending them in-line to this list. Anything bigger than that should have
a bugzilla entry.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org