[GitHub] [ignite-3] sk0x50 commented on a change in pull request #674: IGNITE-16010 move setBaseline to cluster configuration

[GitBox <gi...@apache.org>]

sk0x50 commented on a change in pull request #674:
URL: https://github.com/apache/ignite-3/pull/674#discussion_r814817344



##########
File path: modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
##########
@@ -332,6 +333,13 @@ public void start(@Nullable String cfg) {
             // Deploy all registered watches because all components are ready and have registered their listeners.
             metaStorageMgr.deployWatches();
 
+            baselineMgr.listenBaselineChange(ctx -> {

Review comment:
       This registration of the given listener looks weird to me. It seems that this can be done in `BaselineManager.start()`. What do you think?

##########
File path: modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
##########
@@ -332,6 +333,13 @@ public void start(@Nullable String cfg) {
             // Deploy all registered watches because all components are ready and have registered their listeners.
             metaStorageMgr.deployWatches();
 
+            baselineMgr.listenBaselineChange(ctx -> {
+                // TODO: Multi invoke supposed to be here https://issues.apache.org/jira/browse/IGNITE-16063
+                metaStorageMgr.put(new ByteArray("some key"), new byte[0]);

Review comment:
       It would be nice to change the name of the key even though it is a "temporary" name. Perhaps, "baseline.nodes".

##########
File path: modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java
##########
@@ -332,6 +333,13 @@ public void start(@Nullable String cfg) {
             // Deploy all registered watches because all components are ready and have registered their listeners.
             metaStorageMgr.deployWatches();
 
+            baselineMgr.listenBaselineChange(ctx -> {
+                // TODO: Multi invoke supposed to be here https://issues.apache.org/jira/browse/IGNITE-16063

Review comment:
       Multi invoke is already implemented and can be used.

##########
File path: modules/baseline/src/main/java/org/apache/ignite/internal/baseline/BaselineManager.java
##########
@@ -31,32 +38,29 @@
 // TODO: https://issues.apache.org/jira/browse/IGNITE-14716 Adapt concept of baseline topology IEP-4.
 @SuppressWarnings({"FieldCanBeLocal", "unused"})
 public class BaselineManager implements IgniteComponent {
-    /** Configuration manager in order to handle and listen baseline specific configuration. */
-    private final ConfigurationManager configurationMgr;
-
-    /**
-     * MetaStorage manager in order to watch private distributed baseline specific configuration, cause ConfigurationManger handles only
-     * public configuration.
-     */
-    private final MetaStorageManager metastorageMgr;
+    /** Cluster configuration in order to handle and listen baseline specific configuration. */
+    private final ClusterConfiguration clusterConfiguration;
 
     /** Cluster network service in order to retrieve information about current cluster nodes. */
     private final ClusterService clusterSvc;
 
+    /** Busy lock to stop synchronously. */
+    private final IgniteSpinBusyLock busyLock = new IgniteSpinBusyLock();
+
+    /** Prevents double stopping the component. */
+    AtomicBoolean stopGuard = new AtomicBoolean();

Review comment:
       IMHO, I don't think, that this flag is needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org