You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/28 17:21:56 UTC
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4107: Adding ability to use zone root records
rawlinp commented on a change in pull request #4107:
URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r431998459
##########
File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
##########
@@ -458,8 +458,8 @@ private static void generateZones(final TrafficRouter tr, final LoadingCache<Zon
@SuppressWarnings({"PMD.ExcessiveParameterList"})
private static List<Record> createZone(final String domain, final Map<String, List<Record>> zoneMap, final Map<String, DeliveryService> dsMap,
- final TrafficRouter tr, final LoadingCache<ZoneKey, Zone> zc, final LoadingCache<ZoneKey, Zone> dzc, final List<Runnable> generationTasks,
Review comment:
Can I trouble you to undo the extraneous formatting changes in these changed files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org