[GitHub] [spark] huaxingao commented on pull request #39678: [SPARK-16484][SQL] Add HyperLogLogPlusPlus sketch generator/evaluator/aggregator

["huaxingao (via GitHub)" <gi...@apache.org>]

huaxingao commented on PR #39678:
URL: https://github.com/apache/spark/pull/39678#issuecomment-1399184316

   @RyanBerti Thanks for the great work!
   
   +1 for using Apache DataSketches library. 
   
   I am wondering if we can use [Theta Sketches](https://datasketches.apache.org/docs/Theta/ThetaSketchFramework.html) because it supports union, intersection and difference, while HLL sketches only supports union. Trino recently has added the support to use Apache DataSketches's Theta sketch to calculate distinct value, and Apache Iceberg defines Apache DataSketches's Theta as the common data sketch for keeping track of distinct values in a table.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org