You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/23 23:39:23 UTC

[GitHub] [spark] huaxingao opened a new pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

huaxingao opened a new pull request #28913:
URL: https://github.com/apache/spark/pull/28913


   ### What changes were proposed in this pull request?
   Add summary to RandomForestClassificationModel...
   
   ### Why are the changes needed?
   so user can get a summary of this classification model, and retrieve common metrics such as accuracy, weightedTruePositiveRate, roc (for binary), pr curves (for binary), etc.
   
   
   ### Does this PR introduce _any_ user-facing change?
   Yes
   ```
   RandomForestClassificationModel.summary
   RandomForestClassificationModel.evaluate
   ```
   
   ### How was this patch tested?
   Add new tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657972






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650665378






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650675868






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-651250226


   @zhengruifeng 
   Thanks for your comments.
   Seems I have to add summary to each of the Classifiers one by one. Using this PR as an example, I think I need to have the following in RandomForestclassifier.scala, to be consistent with the implementation of LogisticRegressionTrainingSummary.
   ```
   sealed trait RandomForestClassificationSummary extends ClassificationSummary 
   
   sealed trait RandomForestClassificationTrainingSummary extends RandomForestClassificationSummary
     with TrainingSummary
   
   sealed trait BinaryRandomForestClassificationSummary extends BinaryClassificationSummary
   
   sealed trait BinaryRandomForestClassificationTrainingSummary extends
     BinaryRandomForestClassificationSummary with RandomForestClassificationTrainingSummary
   
   private class RandomForestClassificationTrainingSummaryImpl
   
   private class RandomForestClassificationSummaryImpl
   
   private class BinaryRandomForestClassificationTrainingSummaryImpl
   
   private class BinaryRandomForestClassificationSummaryImpl
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650675872


   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124580/
   Test PASSed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648517835


   **[Test build #124434 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124434/testReport)** for PR 28913 at commit [`1e3e3d5`](https://github.com/apache/spark/commit/1e3e3d55c04e09cf2dc91fe3df7031068d05f1ed).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `sealed trait RandomForestClassificationSummary extends ClassificationSummary `
     * `class RandomForestClassificationSummary(_ClassificationSummary):`
     * `class RandomForestClassificationTrainingSummary(RandomForestClassificationSummary,`
     * `class BinaryRandomForestClassificationSummary(_BinaryClassificationSummary):`
     * `class BinaryRandomForestClassificationTrainingSummary(BinaryRandomForestClassificationSummary,`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on a change in pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
huaxingao commented on a change in pull request #28913:
URL: https://github.com/apache/spark/pull/28913#discussion_r444571654



##########
File path: mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
##########
@@ -166,7 +166,35 @@ class RandomForestClassifier @Since("1.4.0") (
     val numFeatures = trees.head.numFeatures
     instr.logNumClasses(numClasses)
     instr.logNumFeatures(numFeatures)
-    new RandomForestClassificationModel(uid, trees, numFeatures, numClasses)
+    createModel(dataset, trees, numFeatures, numClasses)
+  }
+
+  private def createModel(
+      dataset: Dataset[_],
+      trees: Array[DecisionTreeClassificationModel],
+      numFeatures: Int,
+      numClasses: Int): RandomForestClassificationModel = {
+    val model = copyValues(new RandomForestClassificationModel(uid, trees, numFeatures, numClasses))
+    val weightColName = if (!isDefined(weightCol)) "weightCol" else $(weightCol)
+
+    val (summaryModel, probabilityColName, predictionColName) = model.findSummaryModel()
+    val rfSummary = if (numClasses <= 2) {
+      new BinaryRandomForestClassificationTrainingSummaryImpl(
+        summaryModel.transform(dataset),
+        probabilityColName,
+        predictionColName,
+        $(labelCol),
+        weightColName,
+        Array(0.0))

Review comment:
       for non iterative algorithm, set objectiveHistory to Array(0.0). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648518074






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648483421


   **[Test build #124434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124434/testReport)** for PR 28913 at commit [`1e3e3d5`](https://github.com/apache/spark/commit/1e3e3d55c04e09cf2dc91fe3df7031068d05f1ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648483717






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650665378






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen closed pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #28913:
URL: https://github.com/apache/spark/pull/28913


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650675868


   Merged build finished. Test PASSed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657842


   **[Test build #124578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124578/testReport)** for PR 28913 at commit [`e989a3e`](https://github.com/apache/spark/commit/e989a3e0c8adbd2efeff28353a33e7d810ac4770).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] huaxingao commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-652551624


   Thanks! @srowen @zhengruifeng 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657999


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124578/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650665077


   **[Test build #124580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124580/testReport)** for PR 28913 at commit [`55b52bd`](https://github.com/apache/spark/commit/55b52bdb28a001157d0b0b265c687023267bb58c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657972






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648483421


   **[Test build #124434 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124434/testReport)** for PR 28913 at commit [`1e3e3d5`](https://github.com/apache/spark/commit/1e3e3d55c04e09cf2dc91fe3df7031068d05f1ed).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650675689


   **[Test build #124580 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124580/testReport)** for PR 28913 at commit [`55b52bd`](https://github.com/apache/spark/commit/55b52bdb28a001157d0b0b265c687023267bb58c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657995


   **[Test build #124578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124578/testReport)** for PR 28913 at commit [`e989a3e`](https://github.com/apache/spark/commit/e989a3e0c8adbd2efeff28353a33e7d810ac4770).
    * This patch **fails Scala style tests**.
    * This patch **does not merge cleanly**.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650665077


   **[Test build #124580 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124580/testReport)** for PR 28913 at commit [`55b52bd`](https://github.com/apache/spark/commit/55b52bdb28a001157d0b0b265c687023267bb58c).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657842


   **[Test build #124578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124578/testReport)** for PR 28913 at commit [`e989a3e`](https://github.com/apache/spark/commit/e989a3e0c8adbd2efeff28353a33e7d810ac4770).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650710662


   It seems that you need to add summary in ml one by one.
   Is it possible to add it as a generic function in `Classifier`/`Regressor` or even in `Predictor`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648518074






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-650657997






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-648483717






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] srowen commented on pull request #28913: [SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel

Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #28913:
URL: https://github.com/apache/spark/pull/28913#issuecomment-652408546


   Merged to master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org