You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2006/01/30 01:24:33 UTC

[jira] Created: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

The build/site/skin/*.css have extra carriage-return when generated on Windows.
-------------------------------------------------------------------------------

         Key: FOR-805
         URL: http://issues.apache.org/jira/browse/FOR-805
     Project: Forrest
        Type: Bug
  Components: Core operations  
    Versions: 0.7    
    Reporter: David Crossley


For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by David Crossley <cr...@apache.org>.
Thorsten Scherler wrote:
> 
> Further I am not sure that skin/basic.css is actually generated by the
> the forrest bot since we copy the whole skin dir in the build target to
> the project build/site.

Yes it does: main/webapp/resources.xmap line 139
it has the Chaperon pattern transformer look for links.

> It would be very interesting to know whether the skin/basic.css from
> forrest site and forrest run have the same problem.

Jean attached the files to
http://issues.apache.org/jira/browse/FOR-805

Both files are the same.

-David

Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Thorsten Scherler wrote:
> ...
> Further I am not sure that skin/basic.css is actually generated by the
> the forrest bot since we copy the whole skin dir in the build target to
> the project build/site.
> 
> It would be very interesting to know whether the skin/basic.css from
> forrest site and forrest run have the same problem.
> 

I did 'forrest run', but only find one copy of basic.css:

    C:\jta\Apache\incubator>find . -name basic.css -print
    ./site-publish/skin/basic.css

should I be looking somewhere else?

  -jean

p.s. I left an old svn snapshot of the incubator site in place for 
anyone wondering.



Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Thorsten Scherler wrote:
> El mié, 08-02-2006 a las 09:19 +1100, David Crossley escribió:
> 
>>Would you please explain what you mean.
>>
>>-David
>>
>>Thorsten Scherler (JIRA) wrote:
>>
>>>    [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ] 
>>>
>>>Thorsten Scherler commented on FOR-805:
>>>---------------------------------------
>>>
>>><map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
>>>        <encoding>UTF-8</encoding>
>>>      </map:serializer>
>>>
>>>Maybe that is the reason for the additional \r 
> 
> The above is taken from our main sitemap. Now in the resources.xmap that
> is actually handling the final transformation in css you can find:
> <map:serializer name="text" mime-type="text/plain"
> src="org.apache.cocoon.serialization.TextSerializer"/>
> 
> ¡Without! encoding. What I suggest is to add the encoding as well to the
> resource.xmap to see whether that makes the difference (I have the
> feeling that the whole issue could be based on encoding problems).

I tried adding the encoding to main/webapp/resources.xmap, but the 
'forrest run' basic.css and 'forrest site' basic.css still have the 
additional \r's.

However, perhaps I don't understood what to change and where. Here's 
what I tried:

C:\jta\Apache\forrest_07_branch\main\webapp>svn diff resources.xmap
Index: resources.xmap
===================================================================
--- resources.xmap      (revision 372002)
+++ resources.xmap      (working copy)
@@ -47,7 +47,10 @@
              <!-- <parameter name="gamma" type="float" value="0.48"/> -->
              <parameter name="gamma" type="float" value="0"/>
           </map:serializer>
-         <map:serializer name="text"   mime-type="text/plain" 
src="org.apache.cocoon.serialization.TextSerializer"/>
+         <map:serializer name="text"   mime-type="text/plain" 
src="org.apache.cocoon.serialization.TextSerializer">
+            <encoding>UTF-8</encoding>
+         </map:serializer>
+
        </map:serializers>
        <map:transformers default="xslt">
         <map:transformer name="pattern"

regards,

  -jean

Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by Thorsten Scherler <th...@apache.org>.
El mié, 08-02-2006 a las 09:19 +1100, David Crossley escribió:
> Would you please explain what you mean.
> 
> -David
> 
> Thorsten Scherler (JIRA) wrote:
> >     [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ] 
> > 
> > Thorsten Scherler commented on FOR-805:
> > ---------------------------------------
> > 
> > <map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
> >         <encoding>UTF-8</encoding>
> >       </map:serializer>
> > 
> > Maybe that is the reason for the additional \r 


The above is taken from our main sitemap. Now in the resources.xmap that
is actually handling the final transformation in css you can find:
<map:serializer name="text" mime-type="text/plain"
src="org.apache.cocoon.serialization.TextSerializer"/>

¡Without! encoding. What I suggest is to add the encoding as well to the
resource.xmap to see whether that makes the difference (I have the
feeling that the whole issue could be based on encoding problems).


> > 
> > > The build/site/skin/*.css have extra carriage-return when generated on Windows.
> > > -------------------------------------------------------------------------------
> > >
> > >          Key: FOR-805
> > >          URL: http://issues.apache.org/jira/browse/FOR-805
> > >      Project: Forrest
> > >         Type: Bug
> > >   Components: Core operations
> > >     Versions: 0.7
> > >     Reporter: David Crossley
> > 
> > >
> > > For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

Further I am not sure that skin/basic.css is actually generated by the
the forrest bot since we copy the whole skin dir in the build target to
the project build/site.

It would be very interesting to know whether the skin/basic.css from
forrest site and forrest run have the same problem.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Re: [jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by David Crossley <cr...@apache.org>.
Would you please explain what you mean.

-David

Thorsten Scherler (JIRA) wrote:
>     [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ] 
> 
> Thorsten Scherler commented on FOR-805:
> ---------------------------------------
> 
> <map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
>         <encoding>UTF-8</encoding>
>       </map:serializer>
> 
> Maybe that is the reason for the additional \r 
> 
> > The build/site/skin/*.css have extra carriage-return when generated on Windows.
> > -------------------------------------------------------------------------------
> >
> >          Key: FOR-805
> >          URL: http://issues.apache.org/jira/browse/FOR-805
> >      Project: Forrest
> >         Type: Bug
> >   Components: Core operations
> >     Versions: 0.7
> >     Reporter: David Crossley
> 
> >
> > For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

[jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "David Crossley (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12364415 ] 

David Crossley commented on FOR-805:
------------------------------------

Jean T. Anderson reported the issue in:

 http://www.mail-archive.com/dev@forrest.apache.org/msg03667.html
 Subject: Platform-specific svn diffs for three build/site/skin/*.css files
 Date: Tue, 02 Aug 2005 16:55:53 -0700

and

http://www.mail-archive.com/user%40forrest.apache.org/msg01643.html
 Subject: Re: Odd 'diffs' when building incubator site
 Date: Sun, 29 Jan 2006 16:28:13 -0800

> The build/site/skin/*.css have extra carriage-return when generated on Windows.
> -------------------------------------------------------------------------------
>
>          Key: FOR-805
>          URL: http://issues.apache.org/jira/browse/FOR-805
>      Project: Forrest
>         Type: Bug
>   Components: Core operations
>     Versions: 0.7
>     Reporter: David Crossley

>
> For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "Jean T. Anderson (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/FOR-805?page=all ]

Jean T. Anderson updated FOR-805:
---------------------------------

    Attachment: forrest_run_basic.css
                forrest_site_basic.css

forrest_run_basic.css is the result of 'forrest run' + http://localhost:8888/skin/basic.css.
forrest_site_basic.css is what gets generated by the 'forrest site' command and that gets output to skin\basic.css.

> The build/site/skin/*.css have extra carriage-return when generated on Windows.
> -------------------------------------------------------------------------------
>
>          Key: FOR-805
>          URL: http://issues.apache.org/jira/browse/FOR-805
>      Project: Forrest
>         Type: Bug
>   Components: Core operations
>     Versions: 0.7
>     Reporter: David Crossley
>  Attachments: forrest_run_basic.css, forrest_site_basic.css
>
> For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "Jean T. Anderson (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12364481 ] 

Jean T. Anderson commented on FOR-805:
--------------------------------------

Minor clarification: Each line of the copied file (basic.css, print.css, screen.css) has an additional \r.  It's hard to see with the hexdump soup, but readily visible if you open the Windows file with mks vi -- each end of line has an ctrl-M.

> The build/site/skin/*.css have extra carriage-return when generated on Windows.
> -------------------------------------------------------------------------------
>
>          Key: FOR-805
>          URL: http://issues.apache.org/jira/browse/FOR-805
>      Project: Forrest
>         Type: Bug
>   Components: Core operations
>     Versions: 0.7
>     Reporter: David Crossley

>
> For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (FOR-805) The build/site/skin/*.css have extra carriage-return when generated on Windows.

Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/FOR-805?page=comments#action_12365471 ] 

Thorsten Scherler commented on FOR-805:
---------------------------------------

<map:serializer logger="sitemap.serializer.text" mime-type="text/plain" name="text" src="org.apache.cocoon.serialization.TextSerializer">
        <encoding>UTF-8</encoding>
      </map:serializer>

Maybe that is the reason for the additional \r 

> The build/site/skin/*.css have extra carriage-return when generated on Windows.
> -------------------------------------------------------------------------------
>
>          Key: FOR-805
>          URL: http://issues.apache.org/jira/browse/FOR-805
>      Project: Forrest
>         Type: Bug
>   Components: Core operations
>     Versions: 0.7
>     Reporter: David Crossley

>
> For example skin/basic.css gains extra carriage-returns, i.e. '\r\n' becomes '\r\r\n'

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira