You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 03:40:15 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
wu-sheng opened a new pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439
SkyWalking provides browser UI, CLI and GraphQL ways to support extensions. But some users may have the idea to query data
directly from the storage. Such as in ElasticSearch case, Kibana is a great tool to do this.
In default, due to save memory/network and storage space, SkyWalking saves id(s) only in the entity and metadata saved in the
*_inventory entities only. But these tools usually don't support nested query, or don't work conveniently. In this special case,
SkyWalking provide a config to add all necessary name column(s) into the final metrics entities with ID as a trade-off.
Take a look at `core/default/activeExtraModelColumns` config in the `application.yaml`, and set it as `true` to open this feature.
This feature wouldn't provide any new feature to the native SkyWalking scenarios, just for the 3rd party integration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4439: Support name column(s) in the storage for 3rd party integration,
like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#discussion_r387443425
##########
File path: docs/en/setup/backend/backend-setup.md
##########
@@ -115,3 +115,15 @@ which format process is timezone related.
In default, SkyWalking OAP backend choose the OS default timezone.
If you want to override it, please follow Java and OS documents to do so.
+
+#### How to query the storage directly from 3rd party tool?
+SkyWalking provides browser UI, CLI and GraphQL ways to support extensions. But some users may have the idea to query data
+directly from the storage. Such as in ElasticSearch case, Kibana is a great tool to do this.
+
+In default, due to reduce memory, network and storage space usages, SkyWalking saves id(s) only in the entity and metadata saved in the
+*_inventory entities only. But these tools usually don't support nested query, or don't work conveniently. In this special case,
Review comment:
The italic font style is not terminated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#issuecomment-594311461
If we are facing instance relationship, we could have 2 level names too.
I assume these are good enough for the Kibana case at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#issuecomment-594310077
Here are the examples of index
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily merged pull request #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4439:
Support name column(s) in the storage for 3rd party integration,
like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#discussion_r387445087
##########
File path: docs/en/setup/backend/backend-setup.md
##########
@@ -115,3 +115,15 @@ which format process is timezone related.
In default, SkyWalking OAP backend choose the OS default timezone.
If you want to override it, please follow Java and OS documents to do so.
+
+#### How to query the storage directly from 3rd party tool?
+SkyWalking provides browser UI, CLI and GraphQL ways to support extensions. But some users may have the idea to query data
+directly from the storage. Such as in ElasticSearch case, Kibana is a great tool to do this.
+
+In default, due to reduce memory, network and storage space usages, SkyWalking saves id(s) only in the entity and metadata saved in the
+*_inventory entities only. But these tools usually don't support nested query, or don't work conveniently. In this special case,
Review comment:
No, it isn't. How to force it back in the markdown?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily commented on issue #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#issuecomment-594344147
LGTM. This's a handy feature for debugging purposes. I used suffering from switching querying between inventory and metric.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4439: Support name column(s) in the storage for 3rd party integration,
like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#discussion_r387449683
##########
File path: docs/en/setup/backend/backend-setup.md
##########
@@ -115,3 +115,15 @@ which format process is timezone related.
In default, SkyWalking OAP backend choose the OS default timezone.
If you want to override it, please follow Java and OS documents to do so.
+
+#### How to query the storage directly from 3rd party tool?
+SkyWalking provides browser UI, CLI and GraphQL ways to support extensions. But some users may have the idea to query data
+directly from the storage. Such as in ElasticSearch case, Kibana is a great tool to do this.
+
+In default, due to reduce memory, network and storage space usages, SkyWalking saves id(s) only in the entity and metadata saved in the
+*_inventory entities only. But these tools usually don't support nested query, or don't work conveniently. In this special case,
Review comment:
`*` and `_` should appear in pair IMO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4439: Support name
column(s) in the storage for 3rd party integration, like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#issuecomment-594348923
> LGTM. This's a handy feature for debugging purposes. I used suffering from switching querying between inventory and metric.
It could work as a debug feature if you like :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4439:
Support name column(s) in the storage for 3rd party integration,
like Kibana. Default OFF
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4439: Support name column(s) in the storage for 3rd party integration, like Kibana. Default OFF
URL: https://github.com/apache/skywalking/pull/4439#discussion_r387458202
##########
File path: docs/en/setup/backend/backend-setup.md
##########
@@ -115,3 +115,15 @@ which format process is timezone related.
In default, SkyWalking OAP backend choose the OS default timezone.
If you want to override it, please follow Java and OS documents to do so.
+
+#### How to query the storage directly from 3rd party tool?
+SkyWalking provides browser UI, CLI and GraphQL ways to support extensions. But some users may have the idea to query data
+directly from the storage. Such as in ElasticSearch case, Kibana is a great tool to do this.
+
+In default, due to reduce memory, network and storage space usages, SkyWalking saves id(s) only in the entity and metadata saved in the
+*_inventory entities only. But these tools usually don't support nested query, or don't work conveniently. In this special case,
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services