[GitHub] jadatkins commented on issue #1521: install from script fails due to new filename

[GitBox <gi...@apache.org>]

jadatkins commented on issue #1521: install from script fails due to new filename
URL: https://github.com/apache/incubator-pagespeed-ngx/issues/1521#issuecomment-355953486
 
 
   The problem is here
   https://github.com/apache/incubator-pagespeed-ngx/blob/ccaa714a85dd7b73d2b144e59167f4fa086ab53a/scripts/build_ngx_pagespeed.sh#L614-L619
   
   In my case, line 614 expands to
   ```sh
   run wget https://github.com/pagespeed/ngx_pagespeed/archive/v1.12.34.1-beta.zip -O /tmp/tmp.RvJfZmXZCb/ngx_pagespeed-1.12.34.1-beta.zip`
   ```
   and https://github.com/pagespeed/ngx_pagespeed/archive/v1.12.34.1-beta.zip redirects to https://codeload.github.com/apache/incubator-pagespeed-ngx/zip/v1.12.34.1-beta
   
   Everything up to line 618 works, but line 619 expands to
   ```sh
   cd /root/ngx_pagespeed-1.12.34.1-beta
   ```
   
   and here is the problem:
   ```
   $ ls /root
   incubator-pagespeed-ngx-1.12.34.1-beta
   ```
   
   If you download that zip file, you will see that inside it is a folder called `incubator-pagespeed-ngx-1.12.34.1-beta` instead of `ngx_pagespeed-1.12.34.1-beta`, which is what it used to be.
   
   I will submit a pull request to fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services