You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2008/01/30 18:42:32 UTC
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util
Hi Mike
On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
> Author: cmpilato
> Date: Tue Jan 29 12:37:29 2008
> New Revision: 29076
>
> Log:
> Bump the libsvn_fs_base format number, and disallow node-origin and
> mergeinfo calculations and queries on older versions of the schema.
> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> don't auto-upgrade the schema.
>
After this commit this Ruby bindings test (annotated and slightly modified for
clarity) fails...
-----------------------------------------------------------------------------
# Do something we can test against in the test repo
log = "sample log"
file = "hello.txt"
path = File.join(@wc_path, file)
FileUtils.touch(path)
ctx = make_context(log)
ctx.add(path)
commit_info = ctx.commit(@wc_path)
rev = commit_info.revision
# Things are as we expect
assert_equal(log, ctx.log_message(path, rev))
# Move wholesale the repo folders into a new place
backup_path = File.join(@tmp_path, "back")
FileUtils.mv(@fs.path, backup_path)
FileUtils.mkdir_p(@fs.path)
# Assert that the repo is wacky
assert_raises(Svn::Error::RaLocalReposOpenFailed) do
ctx.log_message(path, rev)
end
# Hotcopy from our new place back to the repo location
Svn::Fs.hotcopy(backup_path, @fs.path)
# Things are okay again
assert_equal(log, ctx.log_message(path, rev))
-----------------------------------------------------------------------------
like this:
D:\SVN\src-trunk\subversion\bindings\swig\ruby>test\run-test.rb
test\test_fs.rb -n test_hotcopy
Loaded suite test_fs.rb
Started
E
Finished in 3.254 seconds.
1) Error:
test_hotcopy(SvnFsTest):
Svn::Error::SvnError:
D:\SVN\src-trunk\subversion\libsvn_subr\io.c:2626 Can't open file
'test\repos\db\format': The file exists.
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_fs_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/fs.rb:47:in `hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:93:in
`test_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:87:in
`assert_hotcopy'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_fs.rb:92:in
`test_hotcopy'
1 tests, 2 assertions, 0 failures, 1 errors
-----------------------------------------------------------------------------
I put traces in svn_io_file_open() and reverted this commit. Before this
change svn_fs_hotcopy() only opened 'test\repos\db\format' once. I reapplied
the changes and sure enough, we are trying to open it a second time.
Perhaps this is not a reasonable test? Or did the bindings test catch
something?
--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util
Posted by Joe Swatosh <jo...@gmail.com>.
On Feb 7, 2008 1:03 AM, C. Michael Pilato <cm...@collab.net> wrote:
>
> Joe Swatosh wrote:
> > On Jan 30, 2008 11:47 AM, C. Michael Pilato <cm...@collab.net> wrote:
> >> David Glasser wrote:
> >>> On Jan 30, 2008 11:24 AM, Joe Swatosh <jo...@gmail.com> wrote:
> >>>> On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
> >>>>> Joe Swatosh wrote:
> >>>>>> Hi Mike
> >>>>>>
> >>>>>> On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
> >>>>>>> Author: cmpilato
> >>>>>>> Date: Tue Jan 29 12:37:29 2008
> >>>>>>> New Revision: 29076
> >>>>>>>
> >>>>>>> Log:
> >>>>>>> Bump the libsvn_fs_base format number, and disallow node-origin and
> >>>>>>> mergeinfo calculations and queries on older versions of the schema.
> >>>>>>> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> >>>>>>> don't auto-upgrade the schema.
> >>>>>>>
> >>>>>> After this commit this Ruby bindings test (annotated and slightly modified for
> >>>>>> clarity) fails...
> >>>>> [...]
> >>>>>
> >>>>>> Perhaps this is not a reasonable test? Or did the bindings test catch
> >>>>>> something?
> >>>>> I think the bindings caught something, and I know what it was they caught.
> >>>>> Out of curiousity, do the tests only fail for BDB-backed repositories?
> >>>>>
> >>>> Nope. Only running against fsfs repositories.
> >>> But r29076 was the change that made it fail? That's odd, since it
> >>> only touches libsvn_fs_base.
> >> Indeed. And I can read BDB logic and see where I think the problem actually is.
> >>
> >
> > I went back and forth between r29075 and r29076 several times trying to figure
> > things out and it failed everytime with r29076. I'm about to have to go back to
> > work so I won't be able to respond quickly, but if there is some additional info
> > I can provide....
>
> I believe you are mistaken about the FSFS-ness of the tests. When I made
You may be right. All I did was stop the test after setup, preventing
the cleanup. The
contents of the repos/db/fs-type was "fsfs." Seemed reasonable to say it was an
fsfs based repo. Is there a more reliable way to determine?
> the patch "where I think the problem actually [was]" in BDB, I saw two
> hotcopy-related Ruby test failures go away.
>
> Fix committed in r29218.
>
Passing here also. Thanks.
--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb
util
Posted by "C. Michael Pilato" <cm...@collab.net>.
Joe Swatosh wrote:
> On Jan 30, 2008 11:47 AM, C. Michael Pilato <cm...@collab.net> wrote:
>> David Glasser wrote:
>>> On Jan 30, 2008 11:24 AM, Joe Swatosh <jo...@gmail.com> wrote:
>>>> On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
>>>>> Joe Swatosh wrote:
>>>>>> Hi Mike
>>>>>>
>>>>>> On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
>>>>>>> Author: cmpilato
>>>>>>> Date: Tue Jan 29 12:37:29 2008
>>>>>>> New Revision: 29076
>>>>>>>
>>>>>>> Log:
>>>>>>> Bump the libsvn_fs_base format number, and disallow node-origin and
>>>>>>> mergeinfo calculations and queries on older versions of the schema.
>>>>>>> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
>>>>>>> don't auto-upgrade the schema.
>>>>>>>
>>>>>> After this commit this Ruby bindings test (annotated and slightly modified for
>>>>>> clarity) fails...
>>>>> [...]
>>>>>
>>>>>> Perhaps this is not a reasonable test? Or did the bindings test catch
>>>>>> something?
>>>>> I think the bindings caught something, and I know what it was they caught.
>>>>> Out of curiousity, do the tests only fail for BDB-backed repositories?
>>>>>
>>>> Nope. Only running against fsfs repositories.
>>> But r29076 was the change that made it fail? That's odd, since it
>>> only touches libsvn_fs_base.
>> Indeed. And I can read BDB logic and see where I think the problem actually is.
>>
>
> I went back and forth between r29075 and r29076 several times trying to figure
> things out and it failed everytime with r29076. I'm about to have to go back to
> work so I won't be able to respond quickly, but if there is some additional info
> I can provide....
I believe you are mistaken about the FSFS-ness of the tests. When I made
the patch "where I think the problem actually [was]" in BDB, I saw two
hotcopy-related Ruby test failures go away.
Fix committed in r29218.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util
Posted by Joe Swatosh <jo...@gmail.com>.
On Jan 30, 2008 11:47 AM, C. Michael Pilato <cm...@collab.net> wrote:
>
> David Glasser wrote:
> > On Jan 30, 2008 11:24 AM, Joe Swatosh <jo...@gmail.com> wrote:
> >> On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
> >>> Joe Swatosh wrote:
> >>>> Hi Mike
> >>>>
> >>>> On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
> >>>>> Author: cmpilato
> >>>>> Date: Tue Jan 29 12:37:29 2008
> >>>>> New Revision: 29076
> >>>>>
> >>>>> Log:
> >>>>> Bump the libsvn_fs_base format number, and disallow node-origin and
> >>>>> mergeinfo calculations and queries on older versions of the schema.
> >>>>> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> >>>>> don't auto-upgrade the schema.
> >>>>>
> >>>>
> >>>> After this commit this Ruby bindings test (annotated and slightly modified for
> >>>> clarity) fails...
> >>> [...]
> >>>
> >>>> Perhaps this is not a reasonable test? Or did the bindings test catch
> >>>> something?
> >>> I think the bindings caught something, and I know what it was they caught.
> >>> Out of curiousity, do the tests only fail for BDB-backed repositories?
> >>>
> >> Nope. Only running against fsfs repositories.
> >
> > But r29076 was the change that made it fail? That's odd, since it
> > only touches libsvn_fs_base.
>
> Indeed. And I can read BDB logic and see where I think the problem actually is.
>
I went back and forth between r29075 and r29076 several times trying to figure
things out and it failed everytime with r29076. I'm about to have to go back to
work so I won't be able to respond quickly, but if there is some additional info
I can provide....
--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb
util
Posted by "C. Michael Pilato" <cm...@collab.net>.
David Glasser wrote:
> On Jan 30, 2008 11:24 AM, Joe Swatosh <jo...@gmail.com> wrote:
>> On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
>>> Joe Swatosh wrote:
>>>> Hi Mike
>>>>
>>>> On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
>>>>> Author: cmpilato
>>>>> Date: Tue Jan 29 12:37:29 2008
>>>>> New Revision: 29076
>>>>>
>>>>> Log:
>>>>> Bump the libsvn_fs_base format number, and disallow node-origin and
>>>>> mergeinfo calculations and queries on older versions of the schema.
>>>>> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
>>>>> don't auto-upgrade the schema.
>>>>>
>>>>
>>>> After this commit this Ruby bindings test (annotated and slightly modified for
>>>> clarity) fails...
>>> [...]
>>>
>>>> Perhaps this is not a reasonable test? Or did the bindings test catch
>>>> something?
>>> I think the bindings caught something, and I know what it was they caught.
>>> Out of curiousity, do the tests only fail for BDB-backed repositories?
>>>
>> Nope. Only running against fsfs repositories.
>
> But r29076 was the change that made it fail? That's odd, since it
> only touches libsvn_fs_base.
Indeed. And I can read BDB logic and see where I think the problem actually is.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util
Posted by David Glasser <gl...@davidglasser.net>.
On Jan 30, 2008 11:24 AM, Joe Swatosh <jo...@gmail.com> wrote:
> On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
> > Joe Swatosh wrote:
> > > Hi Mike
> > >
> > > On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
> > >> Author: cmpilato
> > >> Date: Tue Jan 29 12:37:29 2008
> > >> New Revision: 29076
> > >>
> > >> Log:
> > >> Bump the libsvn_fs_base format number, and disallow node-origin and
> > >> mergeinfo calculations and queries on older versions of the schema.
> > >> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> > >> don't auto-upgrade the schema.
> > >>
> > >
> > >
> > > After this commit this Ruby bindings test (annotated and slightly modified for
> > > clarity) fails...
> >
> > [...]
> >
> > > Perhaps this is not a reasonable test? Or did the bindings test catch
> > > something?
> >
> > I think the bindings caught something, and I know what it was they caught.
> > Out of curiousity, do the tests only fail for BDB-backed repositories?
> >
>
> Nope. Only running against fsfs repositories.
But r29076 was the change that made it fail? That's odd, since it
only touches libsvn_fs_base.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb util
Posted by Joe Swatosh <jo...@gmail.com>.
On Jan 30, 2008 11:05 AM, C. Michael Pilato <cm...@collab.net> wrote:
> Joe Swatosh wrote:
> > Hi Mike
> >
> > On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
> >> Author: cmpilato
> >> Date: Tue Jan 29 12:37:29 2008
> >> New Revision: 29076
> >>
> >> Log:
> >> Bump the libsvn_fs_base format number, and disallow node-origin and
> >> mergeinfo calculations and queries on older versions of the schema.
> >> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
> >> don't auto-upgrade the schema.
> >>
> >
> >
> > After this commit this Ruby bindings test (annotated and slightly modified for
> > clarity) fails...
>
> [...]
>
> > Perhaps this is not a reasonable test? Or did the bindings test catch
> > something?
>
> I think the bindings caught something, and I know what it was they caught.
> Out of curiousity, do the tests only fail for BDB-backed repositories?
>
Nope. Only running against fsfs repositories.
--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r29076 - in trunk/subversion/libsvn_fs_base: . bdb
util
Posted by "C. Michael Pilato" <cm...@collab.net>.
Joe Swatosh wrote:
> Hi Mike
>
> On Jan 29, 2008 12:37 PM, <cm...@tigris.org> wrote:
>> Author: cmpilato
>> Date: Tue Jan 29 12:37:29 2008
>> New Revision: 29076
>>
>> Log:
>> Bump the libsvn_fs_base format number, and disallow node-origin and
>> mergeinfo calculations and queries on older versions of the schema.
>> Honor the --pre-1.5-compatible flag provided by 'svnadmin create', and
>> don't auto-upgrade the schema.
>>
>
>
> After this commit this Ruby bindings test (annotated and slightly modified for
> clarity) fails...
[...]
> Perhaps this is not a reasonable test? Or did the bindings test catch
> something?
I think the bindings caught something, and I know what it was they caught.
Out of curiousity, do the tests only fail for BDB-backed repositories?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand