You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/07/28 01:32:20 UTC
[GitHub] [netbeans] moacirrf opened a new pull request #3077: 2443-Fix-Can't start profiler windows
moacirrf opened a new pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077
https://issues.apache.org/jira/browse/NETBEANS-2443
Fix start of profiler on windows the bug was caused by wrong command generated, so i compare de both command to checkout whats the difference, on left side version 12.0 that works fine.
After the change
I try don't mess thing so much, because i don't understand why so much lines are generated, but a tested on Linux and windows.
Run, Debug e Profiler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf edited a comment on pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf edited a comment on pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#issuecomment-888370822
> The reasons are more deeper: I fear this patch will fix the profiler, but will break other code that may use e.g. system properties that contains spaces or other 'illegal' chars. As noted in [NETBEANS-5732](https://issues.apache.org/jira/browse/NETBEANS-5732), the culprit is the profiler integration which quotes the output of StartupExtender, when it should not.
Yes, is possible, i will test with netbeans on path with spaces, and use in more scenarios and i will try understand
this StartupExtender.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf edited a comment on pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf edited a comment on pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#issuecomment-888370822
> The reasons are more deeper: I fear this patch will fix the profiler, but will break other code that may use e.g. system properties that contains spaces or other 'illegal' chars. As noted in [NETBEANS-5732](https://issues.apache.org/jira/browse/NETBEANS-5732), the culprit is the profiler integration which quotes the output of StartupExtender, when it should not.
Yes, is possible, i will test with netbeans on path with spaces, and use it for more time.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf commented on pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf commented on pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#issuecomment-888370822
> The reasons are more deeper: I fear this patch will fix the profiler, but will break other code that may use e.g. system properties that contains spaces or other 'illegal' chars. As noted in [NETBEANS-5732](https://issues.apache.org/jira/browse/NETBEANS-5732), the culprit is the profiler integration which quotes the output of StartupExtender, when it should not.
Yes, is possible...i will test with netbeans on path with spaces.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf edited a comment on pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf edited a comment on pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#issuecomment-888370822
> The reasons are more deeper: I fear this patch will fix the profiler, but will break other code that may use e.g. system properties that contains spaces or other 'illegal' chars. As noted in [NETBEANS-5732](https://issues.apache.org/jira/browse/NETBEANS-5732), the culprit is the profiler integration which quotes the output of StartupExtender, when it should not.
Yes, is possible, i will test with netbeans on path with spaces, and use in more scenarios.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf commented on a change in pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf commented on a change in pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#discussion_r678251195
##########
File path: java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
##########
@@ -424,9 +421,8 @@ public void run() {
}
//skip envs, these get filled in later.
//#228901 since u21 we need to use cmd /c to execute on windows, quotes get escaped and when there is space in value, the value gets wrapped in quotes.
- String value = (Utilities.isWindows() ? entry.getValue().replace(quote, escaped) : entry.getValue().replace(quote, "'"));
+ String value = (Utilities.isWindows() ? entry.getValue().replace(quote, "") : entry.getValue().replace(quote, "'"));
if (Utilities.isWindows() && value.endsWith("\"")) {
- //#201132 property cannot end with 2 double quotes, add a space to the end after our quote to prevent the state
Review comment:
humm..I will put again this comment
##########
File path: java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
##########
@@ -424,9 +421,8 @@ public void run() {
}
//skip envs, these get filled in later.
//#228901 since u21 we need to use cmd /c to execute on windows, quotes get escaped and when there is space in value, the value gets wrapped in quotes.
- String value = (Utilities.isWindows() ? entry.getValue().replace(quote, escaped) : entry.getValue().replace(quote, "'"));
+ String value = (Utilities.isWindows() ? entry.getValue().replace(quote, "") : entry.getValue().replace(quote, "'"));
if (Utilities.isWindows() && value.endsWith("\"")) {
- //#201132 property cannot end with 2 double quotes, add a space to the end after our quote to prevent the state
Review comment:
humm..I will put again this comment
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] moacirrf closed pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
moacirrf closed pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#issuecomment-888203142
The reasons are more deeper: I fear this patch will fix the profiler, but will break other code that may use e.g. system properties that contains spaces or other 'illegal' chars. As noted in [NETBEANS-5732](https://issues.apache.org/jira/browse/NETBEANS-5732), the culprit is the profiler integration which quotes the output of StartupExtender, when it should not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on a change in pull request #3077: [NETBEANS-2443] Fix-Can't start profiler windows
Posted by GitBox <gi...@apache.org>.
ebarboni commented on a change in pull request #3077:
URL: https://github.com/apache/netbeans/pull/3077#discussion_r678160043
##########
File path: java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
##########
@@ -424,9 +421,8 @@ public void run() {
}
//skip envs, these get filled in later.
//#228901 since u21 we need to use cmd /c to execute on windows, quotes get escaped and when there is space in value, the value gets wrapped in quotes.
- String value = (Utilities.isWindows() ? entry.getValue().replace(quote, escaped) : entry.getValue().replace(quote, "'"));
+ String value = (Utilities.isWindows() ? entry.getValue().replace(quote, "") : entry.getValue().replace(quote, "'"));
if (Utilities.isWindows() && value.endsWith("\"")) {
- //#201132 property cannot end with 2 double quotes, add a space to the end after our quote to prevent the state
Review comment:
may no need to remove this comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists