You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by GitBox <gi...@apache.org> on 2020/11/03 23:36:48 UTC

[GitHub] [griffin] guoyuepeng commented on a change in pull request #586: Change connectors to connector for datasource

guoyuepeng commented on a change in pull request #586:
URL: https://github.com/apache/griffin/pull/586#discussion_r517017612



##########
File path: service/src/main/java/org/apache/griffin/core/util/MeasureUtil.java
##########
@@ -90,8 +88,7 @@ private static void validateExternalMeasure(ExternalMeasure measure) {
         Set<String> sets = new HashSet<>();
         List<DataSource> sources = measure.getDataSources();
         for (DataSource source : sources) {
-            source.getConnectors().stream().filter(dc -> dc.getName() != null)
-                .forEach(dc -> sets.add(dc.getName()));
+            sets.add(source.getConnector().getName());

Review comment:
       we will add null check here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org