You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/04 23:12:57 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #2001: iss1980 a special close flag added to indicate that the writer is closed

rdblue commented on a change in pull request #2001:
URL: https://github.com/apache/iceberg/pull/2001#discussion_r551623386



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -170,6 +181,9 @@ private void flushRowGroup(boolean finished) {
   }
 
   private void startRowGroup() {
+    if (this.closed) {
+      throw new IllegalStateException("writer is closed");

Review comment:
       Error messages should begin with a capital letter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org