[jira] [Commented] (PARQUET-1654) Remove unnecessary options when building thrift

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932051#comment-16932051 ] 

ASF GitHub Bot commented on PARQUET-1654:
-----------------------------------------

sekikn commented on pull request #676: PARQUET-1654: Remove unnecessary options when building thrift
URL: https://github.com/apache/parquet-mr/pull/676
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-1654
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No additional test, since it's a fix for the CI script. I confirmed the CI succeeded with this fix on Travis using my GitHub repository.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove unnecessary options when building thrift
> -----------------------------------------------
>
>                 Key: PARQUET-1654
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1654
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-thrift
>            Reporter: Kengo Seki
>            Assignee: Kengo Seki
>            Priority: Minor
>              Labels: pull-request-available
>
> In {{dev/travis-before_install.sh}}, configure options for thrift are defined as follows:
> {code}
> ./configure --disable-gen-erl --disable-gen-hs --without-ruby --without-haskell --without-erlang --without-php --without-nodejs
> {code}
> And the following libraries are enabled on Travis:
> {code}
> thrift 0.12.0
> Building C (GLib) Library .... : yes
> Building C# (Mono) Library ... : no
> Building C++ Library ......... : yes
> Building Common Lisp Library.. : no
> Building D Library ........... : no
> Building Dart Library ........ : no
> Building dotnetcore Library .. : no
> Building Erlang Library ...... : no
> Building Go Library .......... : yes
> Building Haskell Library ..... : no
> Building Haxe Library ........ : no
> Building Java Library ........ : yes
> Building Lua Library ......... : no
> Building NodeJS Library ...... : no
> Building Perl Library ........ : no
> Building PHP Library ......... : no
> Building Plugin Support ...... : no
> Building Python Library ...... : yes
> Building Py3 Library ......... : yes
> Building Ruby Library ........ : no
> Building Rust Library ........ : no
> {code}
> But Parquet requires only the C++ library to be installed, so we can disable C, Go, Java, and Python2 (Python3 doesn't seem to be disabled). This will save about 30 seconds on each CI run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)