You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Yongjun Park <th...@gmail.com> on 2014/02/17 11:09:40 UTC
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 17, 2014, 7:09 p.m.)
Review request for Tajo.
Summary (updated)
-----------------
TAJO-594: MySQL store doesn't work.
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 1ac9d80
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java 6f1b612
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java e9c5a03
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/#review35252
-----------------------------------------------------------
Ship it!
+1
Yongjun, thank you for your contribution.
I'll commit it to the master branch.
Please attach it to JIRA. :)
Cheers
Jaehwa
- Jung JaeHwa
On Feb. 24, 2014, 3:07 a.m., Yongjun Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18180/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 3:07 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-594
> https://issues.apache.org/jira/browse/TAJO-594
>
>
> Repository: tajo
>
>
> Description
> -------
>
> When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
>
> {noformat}
> 2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
> java.io.IOException: Unknown column 'TID' in 'field list
> at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
> at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
> at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
> at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
> at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
> at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
> at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
> at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
> at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
> at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
> {noformat}
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
>
> Diff: https://reviews.apache.org/r/18180/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> environment
> * Derby
> * MySQL 5.6.10 with lower_case_table_names=1
>
>
> Thanks,
>
> Yongjun Park
>
>
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Yongjun Park <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 3:07 a.m.)
Review request for Tajo.
Changes
-------
Thanks, I fixed it.
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/#review35250
-----------------------------------------------------------
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65706>
You had better remove it because following iteration prints dropped table name.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65707>
Could you explain why you use putAll()?
If dropBaseTable method finished, baseTableMaps has never been called.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
<https://reviews.apache.org/r/18180/#comment65708>
Please refer my comments at DerbyStore.
- Jung JaeHwa
On Feb. 24, 2014, 2:38 a.m., Yongjun Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18180/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 2:38 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-594
> https://issues.apache.org/jira/browse/TAJO-594
>
>
> Repository: tajo
>
>
> Description
> -------
>
> When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
>
> {noformat}
> 2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
> java.io.IOException: Unknown column 'TID' in 'field list
> at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
> at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
> at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
> at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
> at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
> at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
> at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
> at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
> at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
> at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
> {noformat}
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
>
> Diff: https://reviews.apache.org/r/18180/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> environment
> * Derby
> * MySQL 5.6.10 with lower_case_table_names=1
>
>
> Thanks,
>
> Yongjun Park
>
>
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Yongjun Park <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 2:38 a.m.)
Review request for Tajo.
Changes
-------
removed additional executeBatch()
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Yongjun Park <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 2:18 a.m.)
Review request for Tajo.
Changes
-------
Thanks for reviewing. I update a new patch.
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/#review35157
-----------------------------------------------------------
Hi, YongJun.
I checked the updated patch, and I wrote some comments.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65564>
I recommend for you to addBatch instead of executeUpdate. If you use addBatch, you need to remove a log message before this line.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65565>
I recommend for you to addBatch instead of executeUpdate.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
<https://reviews.apache.org/r/18180/#comment65566>
Please refer my comments at DerbyStore.
- Jung JaeHwa
On Feb. 21, 2014, 9:35 a.m., Yongjun Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18180/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 9:35 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-594
> https://issues.apache.org/jira/browse/TAJO-594
>
>
> Repository: tajo
>
>
> Description
> -------
>
> When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
>
> {noformat}
> 2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
> java.io.IOException: Unknown column 'TID' in 'field list
> at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
> at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
> at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
> at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
> at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
> at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
> at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
> at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
> at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
> at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
> {noformat}
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
>
> Diff: https://reviews.apache.org/r/18180/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> environment
> * Derby
> * MySQL 5.6.10 with lower_case_table_names=1
>
>
> Thanks,
>
> Yongjun Park
>
>
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Yongjun Park <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 9:35 a.m.)
Review request for Tajo.
Changes
-------
Thanks JaeHwa, I upload a new patch referring to your reviews.
As you may know, however, in case that MySQL configured case insensitive, it needs to handle table names with case insensitive. MySQL returns lower case table name even it created by upper case.
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/#review35137
-----------------------------------------------------------
Hi Yongjun.
Thank you for your contribution.
Bug-fix updated nicely, but codes for drop table have some problems.
So, I commented for it.
Cheers.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
<https://reviews.apache.org/r/18180/#comment65552>
If this method would be called, TajoMaster must shut down with CatalogException message written by you. But current version fail at needUpgrade method.
So, I recommend you to update your patch as follows:
- remove LOG.error
- add throw new CatalogException (after dropBaseTable)
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65553>
I think that drop table code size is long. BaseTableMaps has table names which already was created. How about iterating over a Map EntrySet as follows?
for(Map.Entry<String,Boolean> entry: baseTableMaps.entrySet()) {
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
<https://reviews.apache.org/r/18180/#comment65555>
You'd better remove toUpperCase. Current catalog table names be written in upper case. So, toUpperCase doesn't matter. But if we rename it in lower case, it will be lack.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
<https://reviews.apache.org/r/18180/#comment65554>
Please refer my comments for DerbyStore.
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
<https://reviews.apache.org/r/18180/#comment65556>
Please refer my comments for DerbyStore.
- Jung JaeHwa
On Feb. 21, 2014, 6:06 a.m., Yongjun Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18180/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 6:06 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-594
> https://issues.apache.org/jira/browse/TAJO-594
>
>
> Repository: tajo
>
>
> Description
> -------
>
> When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
>
> {noformat}
> 2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
> java.io.IOException: Unknown column 'TID' in 'field list
> at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
> at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
> at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
> at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
> at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
> at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
> at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
> at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
> at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
> at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
> at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
> {noformat}
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
>
> Diff: https://reviews.apache.org/r/18180/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
> environment
> * Derby
> * MySQL 5.6.10 with lower_case_table_names=1
>
>
> Thanks,
>
> Yongjun Park
>
>
Re: Review Request 18180: TAJO-594: MySQL store doesn't work.
Posted by Yongjun Park <th...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18180/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 6:06 a.m.)
Review request for Tajo.
Changes
-------
I've updated a patch for this issue based on TAJO-530
Bugs: TAJO-594
https://issues.apache.org/jira/browse/TAJO-594
Repository: tajo
Description
-------
When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.
{noformat}
2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
java.io.IOException: Unknown column 'TID' in 'field list
at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
{noformat}
Diffs (updated)
-----
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java 8c2c0c3
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java b4bd605
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java d78e734
Diff: https://reviews.apache.org/r/18180/diff/
Testing
-------
mvn clean install
environment
* Derby
* MySQL 5.6.10 with lower_case_table_names=1
Thanks,
Yongjun Park