You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/30 19:20:38 UTC
[GitHub] [airflow] madison-ookla opened a new pull request #13392: Add upgrade check option to list checks
madison-ookla opened a new pull request #13392:
URL: https://github.com/apache/airflow/pull/13392
Closes #13378
This PR adds a `--list` option to the upgrade check to list both the check title and class name (for use when ignoring certain checks).
Example output:
```
$ airflow upgrade_check --list
Upgrade Checks:
- Check for latest versions of apache-airflow and checker [VersionCheckRule]
- Remove airflow.AirflowMacroPlugin class [AirflowMacroPluginRemovedRule]
- Chain between DAG and operator not allowed. [ChainBetweenDAGAndOperatorNotAllowedRule]
- Connection.conn_id is not unique [UniqueConnIdRule]
- Connection.conn_type is not nullable [ConnTypeIsNotNullableRule]
- Ensure users are not using custom metaclasses in custom operators [BaseOperatorMetaclassRule]
- Hooks that run DB functions must inherit from DBApiHook [DbApiRule]
- Fernet is enabled by default [FernetEnabledRule]
- GCP service account key deprecation [GCPServiceAccountKeyRule]
- Unify hostname_callable option in core section [HostnameCallable]
- Changes in import paths of hooks, operators, sensors and others [ImportChangesRule]
- Legacy UI is deprecated by default [LegacyUIDeprecated]
- Logging configuration has been moved to new section [LoggingConfigurationRule]
- Removal of Mesos Executor [MesosExecutorRemovedRule]
- No additional argument allowed in BaseOperator. [NoAdditionalArgsInOperatorsRule]
- Users must set a kubernetes.pod_template_file value [PodTemplateFileRule]
- SendGrid email uses old airflow.contrib module [SendGridEmailerMovedRule]
- Changes in import path of remote task handlers [TaskHandlersMovedRule]
- Jinja Template Variables cannot be undefined [UndefinedJinjaVariablesRule]
```
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551583751
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
Sounds good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13392:
URL: https://github.com/apache/airflow/pull/13392
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552247692
##########
File path: tests/upgrade/rules/test_base_rule.py
##########
@@ -25,3 +25,20 @@ def test_rules_are_registered(self):
rule_classes = get_rules()
assert BaseRule not in rule_classes
assert ConnTypeIsNotNullableRule in rule_classes
+
+ def test_rules_are_ordered(self):
+ rule_classes = get_rules()
+ from airflow.upgrade.rules.aaa_airflow_version_check import VersionCheckRule
+ from airflow.upgrade.rules.conn_id_is_unique import UniqueConnIdRule
+ from airflow.upgrade.rules.no_additional_args_in_operators import (
+ NoAdditionalArgsInOperatorsRule,
+ )
+
+ # Version check should still be first
+ assert rule_classes[0] == VersionCheckRule
+ print(rule_classes)
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551520668
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
It looks like the current assumption is that the version check should run first (based off of the fact that these files are run in alphabetical order and it's currently prefixed with `aaa_`: https://github.com/apache/airflow/tree/v1-10-stable/airflow/upgrade/rules). This will alter that order, and I think it might not be best to change the name of the version check class as people may already be ignoring it/using it elsewhere. I'm open to changing this if those concerns aren't as widely shared :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#issuecomment-756283648
@kaxil I love this idea, would it be alright to do a follow-up PR after this to add that? Just so it doesn't hold some of the changes here up.
@turbaszek I am using breeze! But I'm just running the checker directly rather than trying to mess with installations: `./breeze shell -- -c "python airflow/upgrade/checker.py --list"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552856637
##########
File path: airflow/upgrade/checker.py
##########
@@ -94,7 +107,10 @@ def __main__():
parser = argparse.ArgumentParser()
register_arguments(parser)
args = parser.parse_args()
- args.func(args)
+ if args.list:
+ list_checks()
+ else:
+ run(args)
Review comment:
Actually, I think the implementation I had was fine, since I removed the `set_defaults` call on the argument parser too. This won't be recursive. (Double checked by running this locally with success)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552856637
##########
File path: airflow/upgrade/checker.py
##########
@@ -94,7 +107,10 @@ def __main__():
parser = argparse.ArgumentParser()
register_arguments(parser)
args = parser.parse_args()
- args.func(args)
+ if args.list:
+ list_checks()
+ else:
+ run(args)
Review comment:
Actually, I think the implementation I had was fine, since I removed the `set_defaults` call on the argument parser too. This won't be recursive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r550456400
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
```suggestion
for rule in sorted(ALL_RULES, key=lambda r: r.__class__.__name__:
```
This will introduce a nice order. In fact we can even use this `sorted` in definition of `ALL_RULES` to keep it sorted everywhere, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r553068262
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
+ rule_name = rule.__class__.__name__
+ print("- {} [{}]".format(rule.title, rule_name))
Review comment:
Would be awesome to have a tabular format (makes it more readable) like below but not a requirement for this PR :)
```
| ClassName | Description |
|------------------------------------------|-------------------------------------------------------------------|
| VersionCheckRule | Check for latest versions of apache-airflow and checker |
| AirflowMacroPluginRemovedRule | Remove airflow.AirflowMacroPlugin class |
| BaseOperatorMetaclassRule | Ensure users are not using custom metaclasses in custom operators |
| ChainBetweenDAGAndOperatorNotAllowedRule | Chain between DAG and operator not allowed. |
| ConnTypeIsNotNullableRule | Connection.conn_type is not nullable |
| DbApiRule | Hooks that run DB functions must inherit from DBApiHook |
| FernetEnabledRule | Fernet is enabled by default |
| GCPServiceAccountKeyRule | GCP service account key deprecation |
| HostnameCallable | Unify hostname_callable option in core section |
| ImportChangesRule | Changes in import paths of hooks, operators, sensors and others |
| LegacyUIDeprecated | Legacy UI is deprecated by default |
| LoggingConfigurationRule | Logging configuration has been moved to new section |
| MesosExecutorRemovedRule | Removal of Mesos Executor |
| NoAdditionalArgsInOperatorsRule | No additional argument allowed in BaseOperator. |
| PodTemplateFileRule | Users must set a kubernetes.pod_template_file value |
| SendGridEmailerMovedRule | SendGrid email uses old airflow.contrib module |
| TaskHandlersMovedRule | Changes in import path of remote task handlers |
| UndefinedJinjaVariablesRule | Jinja Template Variables cannot be undefined |
| UniqueConnIdRule | Connection.conn_id is not unique |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551581632
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
@madison-ookla how about introducing order here:
https://github.com/apache/airflow/blob/748d05f519c0e5427d2a46763591f03697c4d585/airflow/upgrade/rules/__init__.py#L20-L34
by doing:
```py
return rule_classes[0] + sorted(rule_classes[1:], key=lambda r: r.__class__.__name__)
```
we can assume that check version rule will be first (the files are sorted so `aaa_` will be first) and then we can easily sort it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552852025
##########
File path: airflow/upgrade/checker.py
##########
@@ -94,7 +107,10 @@ def __main__():
parser = argparse.ArgumentParser()
register_arguments(parser)
args = parser.parse_args()
- args.func(args)
+ if args.list:
+ list_checks()
+ else:
+ run(args)
Review comment:
D'oh! Thanks, I'll change this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551650467
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
Review comment:
Just pushed this change, new output (and ordering) looks like this:
```
Upgrade Checks:
- Check for latest versions of apache-airflow and checker [VersionCheckRule]
- Remove airflow.AirflowMacroPlugin class [AirflowMacroPluginRemovedRule]
- Ensure users are not using custom metaclasses in custom operators [BaseOperatorMetaclassRule]
- Chain between DAG and operator not allowed. [ChainBetweenDAGAndOperatorNotAllowedRule]
- Connection.conn_type is not nullable [ConnTypeIsNotNullableRule]
- Hooks that run DB functions must inherit from DBApiHook [DbApiRule]
- Fernet is enabled by default [FernetEnabledRule]
- GCP service account key deprecation [GCPServiceAccountKeyRule]
- Unify hostname_callable option in core section [HostnameCallable]
- Changes in import paths of hooks, operators, sensors and others [ImportChangesRule]
- Legacy UI is deprecated by default [LegacyUIDeprecated]
- Logging configuration has been moved to new section [LoggingConfigurationRule]
- Removal of Mesos Executor [MesosExecutorRemovedRule]
- No additional argument allowed in BaseOperator. [NoAdditionalArgsInOperatorsRule]
- Users must set a kubernetes.pod_template_file value [PodTemplateFileRule]
- SendGrid email uses old airflow.contrib module [SendGridEmailerMovedRule]
- Changes in import path of remote task handlers [TaskHandlersMovedRule]
- Jinja Template Variables cannot be undefined [UndefinedJinjaVariablesRule]
- Connection.conn_id is not unique [UniqueConnIdRule]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#issuecomment-756025442
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552160190
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
+ rule_name = rule.__class__.__name__
+ print("- {} [{}]".format(rule.title, rule_name))
Review comment:
Makes sense! How does this look? (tweaked the formatting just a bit)
```
Upgrade Checks:
- VersionCheckRule: Check for latest versions of apache-airflow and checker
- AirflowMacroPluginRemovedRule: Remove airflow.AirflowMacroPlugin class
- BaseOperatorMetaclassRule: Ensure users are not using custom metaclasses in custom operators
- ChainBetweenDAGAndOperatorNotAllowedRule: Chain between DAG and operator not allowed.
- ConnTypeIsNotNullableRule: Connection.conn_type is not nullable
- DbApiRule: Hooks that run DB functions must inherit from DBApiHook
- FernetEnabledRule: Fernet is enabled by default
- GCPServiceAccountKeyRule: GCP service account key deprecation
- HostnameCallable: Unify hostname_callable option in core section
- ImportChangesRule: Changes in import paths of hooks, operators, sensors and others
- LegacyUIDeprecated: Legacy UI is deprecated by default
- LoggingConfigurationRule: Logging configuration has been moved to new section
- MesosExecutorRemovedRule: Removal of Mesos Executor
- NoAdditionalArgsInOperatorsRule: No additional argument allowed in BaseOperator.
- PodTemplateFileRule: Users must set a kubernetes.pod_template_file value
- SendGridEmailerMovedRule: SendGrid email uses old airflow.contrib module
- TaskHandlersMovedRule: Changes in import path of remote task handlers
- UndefinedJinjaVariablesRule: Jinja Template Variables cannot be undefined
- UniqueConnIdRule: Connection.conn_id is not unique
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r553140103
##########
File path: airflow/upgrade/checker.py
##########
@@ -94,7 +107,10 @@ def __main__():
parser = argparse.ArgumentParser()
register_arguments(parser)
args = parser.parse_args()
- args.func(args)
+ if args.list:
+ list_checks()
+ else:
+ run(args)
Review comment:
Oh, never mind... I missed that it was in `main` function and I thought it was defined in `run`...
<img width="644" alt="Screenshot 2021-01-07 at 07 51 17" src="https://user-images.githubusercontent.com/9528307/103861098-22ee0f80-50bd-11eb-8309-7b0f709f68c0.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r551721720
##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
return all_rule_statuses
+def list_checks():
+ print()
+ print("Upgrade Checks:")
+ for rule in ALL_RULES:
+ rule_name = rule.__class__.__name__
+ print("- {} [{}]".format(rule.title, rule_name))
Review comment:
```suggestion
print("- {} - {}".format(rule_name , rule.title))
```
Now when we have ordering, should we consider changing order of those two so the list really look like sorted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] madison-ookla commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
madison-ookla commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552250726
##########
File path: tests/upgrade/rules/test_base_rule.py
##########
@@ -25,3 +25,20 @@ def test_rules_are_registered(self):
rule_classes = get_rules()
assert BaseRule not in rule_classes
assert ConnTypeIsNotNullableRule in rule_classes
+
+ def test_rules_are_ordered(self):
+ rule_classes = get_rules()
+ from airflow.upgrade.rules.aaa_airflow_version_check import VersionCheckRule
+ from airflow.upgrade.rules.conn_id_is_unique import UniqueConnIdRule
+ from airflow.upgrade.rules.no_additional_args_in_operators import (
+ NoAdditionalArgsInOperatorsRule,
+ )
+
+ # Version check should still be first
+ assert rule_classes[0] == VersionCheckRule
+ print(rule_classes)
Review comment:
GAH thank you, left in my debugging print 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r552523700
##########
File path: airflow/upgrade/checker.py
##########
@@ -94,7 +107,10 @@ def __main__():
parser = argparse.ArgumentParser()
register_arguments(parser)
args = parser.parse_args()
- args.func(args)
+ if args.list:
+ list_checks()
+ else:
+ run(args)
Review comment:
```suggestion
arg.func(args)
```
Right? Otherwise we will have recursion error?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13392: Add upgrade check option to list checks
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#issuecomment-756434567
> @kaxil I love this idea, would it be alright to do a follow-up PR after this to add that? Just so it doesn't hold some of the changes here up.
Absolutely :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org