You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by ah...@apache.org on 2023/06/10 09:56:36 UTC

[causeway] 01/03: CAUSEWAY-3442: test fixes

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit 8c27a836509e2227cf7e7f44210124ce45480149
Author: Andi Huber <ah...@apache.org>
AuthorDate: Sat Jun 10 11:34:49 2023 +0200

    CAUSEWAY-3442: test fixes
---
 .../org/apache/causeway/testdomain/conf/Configuration_usingWicket.java  | 2 +-
 .../causeway/viewer/commons/model/decorators/FormLabelDecorator.java    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
index fc9f3ec96f..80cb62022f 100644
--- a/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
+++ b/regressiontests/stable/src/main/java/org/apache/causeway/testdomain/conf/Configuration_usingWicket.java
@@ -213,7 +213,7 @@ public class Configuration_usingWicket {
         }
 
         public void assertFavoriteBookIs(final BookDto bookDto) {
-            assertLabel(FAVORITE_BOOK_SCALAR_NAME, "Favorite Book:");
+            assertLabel(FAVORITE_BOOK_SCALAR_NAME, "Favorite Book");
             assertComponent(FAVORITE_BOOK_ENTITY_LINK, BookmarkablePageLink.class);
 
             val expectedLinkTitle = bookFactory.apply(bookDto).title();
diff --git a/viewers/commons/model/src/main/java/org/apache/causeway/viewer/commons/model/decorators/FormLabelDecorator.java b/viewers/commons/model/src/main/java/org/apache/causeway/viewer/commons/model/decorators/FormLabelDecorator.java
index 8456a39bff..6da048546c 100644
--- a/viewers/commons/model/src/main/java/org/apache/causeway/viewer/commons/model/decorators/FormLabelDecorator.java
+++ b/viewers/commons/model/src/main/java/org/apache/causeway/viewer/commons/model/decorators/FormLabelDecorator.java
@@ -41,7 +41,7 @@ public interface FormLabelDecorator<T> {
 
         public static FormLabelDecorationModel mandatory(final boolean mandatory) {
             /* used to be suffixed with ':' till 2.0.0-RC1;
-             * however, the question arises what to do in the label RIGHT position
+             * however, the question arises what to do in the label RIGHT position case;
              * and so we concluded, that perhaps its better to remove the suffix colon
              * all together */
             return of(mandatory, "");