[jira] [Commented] (PHOENIX-3351) Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant specific tables

["Maryann Xue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15710316#comment-15710316 ] 

Maryann Xue commented on PHOENIX-3351:
--------------------------------------

My comments were posted above, basically some code refinement suggestions. And if the current patch already works for tenant-id and view-index-id, etc, I think it is good enough for now.

> Implement TODOs in PhoenixTableModify#upsert to allow writes to tenant specific tables
> --------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3351
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3351
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>         Attachments: PHOENIX-3351_WIP.patch
>
>
> While running UDF IT tests came across this TODO which is necessary to implement for tenant specific, local or view indexes tests to pass.
> {noformat}
>             // TODO TenantId, ViewIndexId, UpdatableViewColumns
>             final List<PColumn> mappedColumns = targetTable.tableMapping.getMappedColumns();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)