You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/11 13:10:20 UTC
[GitHub] [tvm] mbaret opened a new pull request, #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
mbaret opened a new pull request, #10961:
URL: https://github.com/apache/tvm/pull/10961
Further adds Relay partitioning support for cuDNN conv2d and log_softmax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
Posted by GitBox <gi...@apache.org>.
masahi merged PR #10961:
URL: https://github.com/apache/tvm/pull/10961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a diff in pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
Posted by GitBox <gi...@apache.org>.
masahi commented on code in PR #10961:
URL: https://github.com/apache/tvm/pull/10961#discussion_r848796077
##########
python/tvm/relay/op/contrib/cudnn.py:
##########
@@ -50,6 +51,8 @@ def partition_for_cudnn(
tvm.IRModule
The partitioned module.
"""
+ if params:
Review Comment:
In my case, I want to pattern match against a mod where batch norm is removed by constant folding + fold scale axis. Param binding is a prereq for these passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
Posted by GitBox <gi...@apache.org>.
mbaret commented on PR #10961:
URL: https://github.com/apache/tvm/pull/10961#issuecomment-1096943556
cc @mbrookhart @masahi PTAL and merge if you're happy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbs-octoml commented on a diff in pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
Posted by GitBox <gi...@apache.org>.
mbs-octoml commented on code in PR #10961:
URL: https://github.com/apache/tvm/pull/10961#discussion_r847810749
##########
python/tvm/relay/op/contrib/cudnn.py:
##########
@@ -50,6 +51,8 @@ def partition_for_cudnn(
tvm.IRModule
The partitioned module.
"""
+ if params:
Review Comment:
Given it's a one liner never figured out why folks want to fold that into every partition function. Cargo culting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbaret commented on pull request #10961: [CUDNN] Add partitioning support for conv2d and log_softmax
Posted by GitBox <gi...@apache.org>.
mbaret commented on PR #10961:
URL: https://github.com/apache/tvm/pull/10961#issuecomment-1095252023
cc @mbs-octoml @mikepapadim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org