You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/10/29 16:58:13 UTC
[jira] [Created] (CASSANDRA-4872) Move manifest into sstable
metadata
Jonathan Ellis created CASSANDRA-4872:
-----------------------------------------
Summary: Move manifest into sstable metadata
Key: CASSANDRA-4872
URL: https://issues.apache.org/jira/browse/CASSANDRA-4872
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Priority: Minor
Fix For: 1.3
Now that we have a metadata component it would be better to keep sstable level there, than in a separate manifest. With information per-sstable we don't need to do a full re-level if there is corruption.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4872) Move manifest into sstable
metadata
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486124#comment-13486124 ]
Sylvain Lebresne commented on CASSANDRA-4872:
---------------------------------------------
bq. With information per-sstable we don't need to do a full re-level if there is corruption.
I'm not completely sure what you mean by that? Even if we do that ticket, we will need to reconstruct the manifest in-memory, and in doing that we might get corruption as well.
I'm not saying I'm completely opposed to the idea, but I'm not I understand the benefits and it does seem to introduce some complexity (you'd have to reconstruct the manifest info from spread out sources).
> Move manifest into sstable metadata
> -----------------------------------
>
> Key: CASSANDRA-4872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4872
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.3
>
>
> Now that we have a metadata component it would be better to keep sstable level there, than in a separate manifest. With information per-sstable we don't need to do a full re-level if there is corruption.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4872) Move manifest into sstable
metadata
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486100#comment-13486100 ]
Jonathan Ellis commented on CASSANDRA-4872:
-------------------------------------------
Possible complexity:
- loading external or from-snapshot sstables will need to ignore the level and start at L0 instead
- there may be code paths where we promote an sstable, unmodified. We'd need to update the level then, making the metadata not-quite-immutable.
> Move manifest into sstable metadata
> -----------------------------------
>
> Key: CASSANDRA-4872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4872
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.3
>
>
> Now that we have a metadata component it would be better to keep sstable level there, than in a separate manifest. With information per-sstable we don't need to do a full re-level if there is corruption.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4872) Move manifest into sstable
metadata
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486142#comment-13486142 ]
Jonathan Ellis commented on CASSANDRA-4872:
-------------------------------------------
bq. I'm not completely sure what you mean by that?
What I mean is, if you lose or corrupt the .manifest right now you're SOL and have to put everything in L0 and start over. If it's per-sstable then you don't have this extra non-sstable component causing fragility.
> Move manifest into sstable metadata
> -----------------------------------
>
> Key: CASSANDRA-4872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4872
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Priority: Minor
> Fix For: 1.3
>
>
> Now that we have a metadata component it would be better to keep sstable level there, than in a separate manifest. With information per-sstable we don't need to do a full re-level if there is corruption.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira