You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/31 14:33:24 UTC
[GitHub] [servicecomb-java-chassis] fanjiang-2021 opened a new pull request #2538: A request without any Accept header field implies that the user agent…
fanjiang-2021 opened a new pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538
A request without any Accept header field implies that the user agent will accept any media type in response。
when consumer sends a request to provider without without any Accept header field, serviceomb-java-chassis SDK will set Accept header empty.
According to RFC regulation, A request without any Accept header field implies that the user agent will accept any media type in response,
so if a consumer sends a request to provider without without any Accept header field, it is more reasonable that serviceomb-java-chassis SDK not set Accept header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] fanjiang-2021 closed pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
fanjiang-2021 closed pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909781470
Thanks for this PR. But I don't understand `when consumer sends a request to provider without without any Accept header field, serviceomb-java-chassis SDK will set Accept header empty.` and this PR. I can't find where java chassis set Accept header when consumer sends a request.
Can you provide detail information about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909781470
Thanks for this PR. But I don't understand `when consumer sends a request to provider without any Accept header field, serviceomb-java-chassis SDK will set Accept header empty.` . I can't find where java chassis set Accept header when consumer sends a request.
Can you provide detail information about this? And it may be better to fix the code where the header is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
liubao68 commented on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909781470
Thanks for this PR. But I don't understand `when consumer sends a request to provider without without any Accept header field, serviceomb-java-chassis SDK will set Accept header empty.` and this PR. I can't find where java chassis set Accept header when consumer sends a request.
Can you provide detail information about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909342993
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2538](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68059a4) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/7d8a71b8768e5c1257b81e5277c762884edda8a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d8a71b) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 68059a4 differs from pull request most recent head 8b0249a. Consider uploading reports for the commit 8b0249a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2538 +/- ##
=========================================
Coverage 77.62% 77.62%
Complexity 1419 1419
=========================================
Files 1597 1597
Lines 42430 42431 +1
Branches 3573 3574 +1
=========================================
+ Hits 32935 32937 +2
+ Misses 8003 8001 -2
- Partials 1492 1493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ervicecomb/config/kie/client/KieConfigManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `49.45% <0.00%> (+0.53%)` | :arrow_up: |
| [...ingmvc/reference/RestTemplateCopyHeaderFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9SZXN0VGVtcGxhdGVDb3B5SGVhZGVyRmlsdGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ervicecomb/foundation/vertx/stream/PumpCommon.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9zdHJlYW0vUHVtcENvbW1vbi5qYXZh) | `70.37% <0.00%> (-7.41%)` | :arrow_down: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+0.38%)` | :arrow_up: |
| [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `100.00% <0.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d8a71b...8b0249a](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] fanjiang-2021 closed pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
fanjiang-2021 closed pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909781470
Thanks for this PR. But I don't understand `when consumer sends a request to provider without any Accept header field, serviceomb-java-chassis SDK will set Accept header empty.` . I can't find where java chassis set Accept header when consumer sends a request.
Can you provide detail information about this? And it may be better to fix the code where the header is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2538: A request without any Accept header field implies that the user agent…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2538:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2538#issuecomment-909342993
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2538](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68059a4) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/7d8a71b8768e5c1257b81e5277c762884edda8a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d8a71b) will **increase** coverage by `0.00%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 68059a4 differs from pull request most recent head 8b0249a. Consider uploading reports for the commit 8b0249a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2538 +/- ##
=========================================
Coverage 77.62% 77.62%
Complexity 1419 1419
=========================================
Files 1597 1597
Lines 42430 42431 +1
Branches 3573 3574 +1
=========================================
+ Hits 32935 32937 +2
+ Misses 8003 8001 -2
- Partials 1492 1493 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ervicecomb/config/kie/client/KieConfigManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50cy9jb25maWcta2llLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29uZmlnL2tpZS9jbGllbnQvS2llQ29uZmlnTWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...mb/config/ConfigCenterConfigurationSourceImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHluYW1pYy1jb25maWcvY29uZmlnLWNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZXJ2aWNlY29tYi9jb25maWcvQ29uZmlnQ2VudGVyQ29uZmlndXJhdGlvblNvdXJjZUltcGwuamF2YQ==) | `49.45% <0.00%> (+0.53%)` | :arrow_up: |
| [...ingmvc/reference/RestTemplateCopyHeaderFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXNwcmluZ212Yy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcHJvdmlkZXIvc3ByaW5nbXZjL3JlZmVyZW5jZS9SZXN0VGVtcGxhdGVDb3B5SGVhZGVyRmlsdGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...ervicecomb/foundation/vertx/stream/PumpCommon.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9zdHJlYW0vUHVtcENvbW1vbi5qYXZh) | `70.37% <0.00%> (-7.41%)` | :arrow_down: |
| [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+0.38%)` | :arrow_up: |
| [...b/core/invocation/timeout/PassingTimeStrategy.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9pbnZvY2F0aW9uL3RpbWVvdXQvUGFzc2luZ1RpbWVTdHJhdGVneS5qYXZh) | `100.00% <0.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7d8a71b...8b0249a](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2538?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org