You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/03/06 21:48:41 UTC
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6273
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
IMPALA-5034: Update Breakpad to newer version
This will give us better support for DWARF version 4, support for
redaction of sensitive data, and a multitude of bug fixes.
The Breakpad project does not do releases, so we update to a somewhat
arbitrary commit:
commit 88e5b2c8806bac3f2c80d2fe80094be5bd371601
Author: Scott Graham <sc...@chromium.org>
Date: Tue Feb 28 11:14:04 2017 -0800
Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/6273/1
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
IMPALA-5034: Update Breakpad to newer version
This will give us better support for DWARF version 4, support for
redaction of sensitive data, and a multitude of bug fixes.
The Breakpad project does not do releases, so we update to a somewhat
arbitrary commit:
commit 88e5b2c8806bac3f2c80d2fe80094be5bd371601
Author: Scott Graham <sc...@chromium.org>
Date: Tue Feb 28 11:14:04 2017 -0800
Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Reviewed-on: http://gerrit.cloudera.org:8080/6273
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/impala-config.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/358/
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
Patch Set 1:
This conflicts with my patch https://gerrit.cloudera.org/#/c/6287/. This is based on an earlier toolchain version than mine so I think this should be merged before mine
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5034: Update Breakpad to newer version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5034: Update Breakpad to newer version
......................................................................
Patch Set 1:
Thank you for the review. I started the submit job and will ping you when it's done.
--
To view, visit http://gerrit.cloudera.org:8080/6273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77eb54c0a9a3ad5d59994b22ef47da5817a7e858
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No