You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Sagara Gunathunga (Commented) (JIRA)" <ji...@apache.org> on 2012/03/19 16:34:37 UTC
[jira] [Commented] (AXIS2-5273) Allow forward-compatibility by
ignoring unexpected enumeration values
[ https://issues.apache.org/jira/browse/AXIS2-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232683#comment-13232683 ]
Sagara Gunathunga commented on AXIS2-5273:
-------------------------------------------
Can you attach a test case or a sample service (source code) you used to test this patch ?
> Allow forward-compatibility by ignoring unexpected enumeration values
> ---------------------------------------------------------------------
>
> Key: AXIS2-5273
> URL: https://issues.apache.org/jira/browse/AXIS2-5273
> Project: Axis2
> Issue Type: Bug
> Components: adb, codegen
> Affects Versions: 1.7.0
> Reporter: Cleber Zarate
> Priority: Minor
> Labels: adb, adb-codegen, enumeration, restriction
> Attachments: patch.txt
>
>
> [AXIS2-4859] has been patched adding the -Eiu option to ignore unexpected elements. However, to truly be forward-compatible, generated code should also ignore unexpected enumeration values.
> Here's the snippet necessary for the adb code generation. I opted to return null when an unexpected enumeration is found, as opposed to skip it:
> ADBBeanTemplate-bean.xsl line 2135:
> // handle unexpected enumeration values properly
> <xsl:if test="$ignoreunexpected">
> log.warn("Unexpected value " + value + " for enumeration <xsl:value-of select="$name"/>");
> return enumeration;
> </xsl:if>
> <xsl:if test="not($ignoreunexpected)">
> if ((enumeration == null) && !((value == null) || (value.equals("")))) {
> throw new java.lang.IllegalArgumentException();
> }
> return enumeration;
> </xsl:if>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org